Clojurians
#cljs-dev
<
2016-11-28
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

dnolen19:11:08

@favila symptom not the cause :slightly_smiling_face:

favila19:11:38

I know, but I am not sure what is expected, not sure what issue to file

favila19:11:27

could be either: 1) data_readers should auto-require (not sure if true), 2) data_readers.cljc from tests should not be on classpath for benchmark (seems likely), 3) ns should require anything its data readers need

dnolen19:11:56

2) is a problem but doesn’t fix the underlying issue

dnolen19:11:08

3) is just how it’s supposed to work

dnolen19:11:33

@anmonteiro https://github.com/clojure/clojurescript/commit/0ec11d2f18672949614b890b5f3002a939e35a88, not sure how you were testing the data readers functionality but this should fix actual problem

dnolen19:11:36

benchmarks can run again now

favila19:11:32

@dnolen if 3, then doesn't cljs.tagged-literals-test need to require clojure.set?

dnolen19:11:01

@favila well technically it should - but not 100% necessary in this case since other tests load it

anmonteiro19:11:18

@dnolen: probably didn't produce an error because any library the data reader tests relied on was in the compiler state

favila19:11:18

that's why test doesn't fail

anmonteiro19:11:01

Which you already said above. Hah, sorry, on phone

favila19:11:46

that data_readers.cljc got on the classpath worries me. Makes me wonder if aot cljs jar includes tests too

favila19:11:51

ok, benchmark includes tests in its classpath just because that's what bin/cljsc does

favila19:11:58

and benchmark invokes it

anmonteiro19:11:24

@favila: right, I dont think the uberjar includes them

favila19:11:03

@anmonteiro double checked, yes aot is fine

dnolen19:11:17

@bja not much shorter, but java -cp cljs.jar:src clojure.main -m cljs.repl.nashorn

favila19:11:25

don't know if its worth making bin/cljsc have test/non-test distinction, benchmark is the only non-test invocation

dnolen19:11:27

oops wrong channel