This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2016-11-28
Channels
- # admin-announcements (1)
- # aleph (3)
- # bangalore-clj (4)
- # beginners (167)
- # boot (14)
- # cider (4)
- # cljs-dev (24)
- # cljsjs (21)
- # cljsrn (33)
- # clojure (214)
- # clojure-greece (2)
- # clojure-italy (2)
- # clojure-korea (16)
- # clojure-russia (29)
- # clojure-spec (31)
- # clojure-uk (86)
- # clojurescript (144)
- # core-matrix (2)
- # cursive (37)
- # datascript (5)
- # datomic (104)
- # devcards (2)
- # events (2)
- # jobs (2)
- # luminus (8)
- # midje (1)
- # nyc (4)
- # off-topic (1)
- # om (39)
- # om-next (1)
- # onyx (47)
- # perun (1)
- # planck (6)
- # proton (2)
- # re-frame (25)
- # reagent (40)
- # spacemacs (9)
- # vim (71)
- # yada (3)
could be either: 1) data_readers should auto-require (not sure if true), 2) data_readers.cljc from tests should not be on classpath for benchmark (seems likely), 3) ns should require anything its data readers need
@anmonteiro https://github.com/clojure/clojurescript/commit/0ec11d2f18672949614b890b5f3002a939e35a88, not sure how you were testing the data readers functionality but this should fix actual problem
@favila well technically it should - but not 100% necessary in this case since other tests load it
@dnolen: probably didn't produce an error because any library the data reader tests relied on was in the compiler state
Which you already said above. Hah, sorry, on phone
that data_readers.cljc got on the classpath worries me. Makes me wonder if aot cljs jar includes tests too
@favila: right, I dont think the uberjar includes them
@anmonteiro double checked, yes aot is fine