This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2016-10-23
Channels
- # beginners (22)
- # cider (6)
- # clara (1)
- # cljs-dev (77)
- # clojure (23)
- # clojure-austin (5)
- # clojure-dusseldorf (1)
- # clojure-france (16)
- # clojure-nl (1)
- # clojure-poland (1)
- # clojure-russia (26)
- # clojure-spec (5)
- # clojurescript (120)
- # datomic (1)
- # events (1)
- # hoplon (158)
- # leiningen (5)
- # off-topic (2)
- # om (24)
- # onyx (19)
- # other-languages (1)
- # ring-swagger (4)
- # sql (1)
- # vim (1)
hey, since I updated the Om to 1.9.293
I was having some compilation issues, I was able to narrow it down to this code:
trying to compile this gives me the error:
but, only when the dependency [com.cognitect/transit-clj "0.8.290"]
is added to the project
I put up a repository with the minimal case here: https://github.com/wilkerlucio/cljs-compilation-fail
can someone please try to reproduce the compilation issue to confirm is not just something local here?
FWIW I know that adding transit as a dep is causing the analysis cache files to be in json format instead of edn
@wilkerlucio i cloned that repo, ran that command, got the same output
thanks for the reproduction @jrheard, so seems something weird is going on there
I opened a Jira ticket for this issue: http://dev.clojure.org/jira/browse/CLJS-1832
I’m working on a port of core.match
to be bootstrapped compatible
I’m almost done
I’ve created a fork of core.match
- https://github.com/viebel/core.match
all the tests from the wiki page of core.match
https://github.com/clojure/core.match/wiki/Basic-usage are passing
And here is a live demo with KLIPSE - http://app.klipse.tech/?cljs_in.gist=viebel/10da8338c4a1573fab8c04989e471704&external-libs=%5Bhttps%3A%2F%2Fraw.githubusercontent.com%2Fviebel%2Fcore.match%2Fmaster%2Fsrc%2Fmain%2Fclojure%2F%5D
of self-hosted core.match
@mfikes couldyou please review my code in https://github.com/viebel/core.match
basically what I did was to take match.clj
from https://github.com/clojure/core.match/blob/master/src/main/clojure/clojure/core/match.clj
renamed in to match.cljc
and make a branch for :cljs
@dnolen could you review it?
Should I submit a patch? where?
clojurescript JIRA or core.match JIRA?
It’s a core.match
path
I cannot find the guideline for creating a patch
Here is the JIRA ticket for core.match
self-host compatible http://dev.clojure.org/jira/browse/MATCH-116
@dnolen @mfikes @anmonteiro your code review would be much appreciated
Good luck and happy talk 🙂
@dnolen about the CLJS-1832, I really believe it's a major because all it takes is having Om (that depends on transit-clj) and a destructuring with #js to break it (and currently untangled.client.data-fetch
has that, making impossible to use with latest clojurescript), can you tell me why you consider it a minor issue?
@wilkerlucio it’s just not a deal breaker sorry
well, the update made previous working code into a code that doens't compile at all
I can if it's my code, but what about when it's on a dependency?
occasionally small regression get in - we can’t go around marking all of these as major
@wilkerlucio FWIW you might get away in your case by specifically depending on transit-clj 0.8.288, instead of 0.8.290, have you tried that?
@anmonteiro I didn't yet, I'll try
this seems more like a regression in transit-java than in the CLJS compiler nevertheless
related to the recent mutex fix for ClojureScript
@anmonteiro same thing happens with 0.8.288
which is a knob for disabling transit encoding - since no doubt other things will arise
@wilkerlucio hrm sorry, you might still be getting a wrong transit-java
dep
make sure you’re on transit-java 0.8.313
or rather anything below 0.8.316
@dnolen thanks for the clarifications, the nob to disable transit encoding would be great
it's this one right? http://dev.clojure.org/jira/browse/CLJS-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#issue-tabs
that’s the one
can you tell me where I should start looking to fix this one? I never digged into cljs compilation code before
@wilkerlucio it’s super simple, the most annoying part is just having to change some signatures
in these locations we should be checking build options to see what we should be writing
@dnolen ok, thanks, I'll check it out
@dnolen the write-cache-file
name is right? I can't find it anywhere on the entire project https://github.com/clojure/clojurescript/search?utf8=%E2%9C%93&q=write-cache-file
@wilkerlucio sorry write-analysis-cache
thanks