Fork me on GitHub
#cljs-dev
<
2016-09-20
>
jetzajac19:09:49

Hello everyone! I’ve built ClojureScript from sources and see this when trying to eval in repl

jetzajac19:09:48

has anybody seen it? what did I do wrong? I just used scripts/build

dnolen19:09:39

@jetzajac can you be a bit more specific - that exception happens when you try to run scripts/build ?

jetzajac19:09:01

@dnolen sorry to be confusing. nope, it happens once I eval anything in a browser repl. build succeeded with no problems

dnolen19:09:10

@jetzajac did you try the Node.js REPL?

jetzajac19:09:27

no, I didn’t. should I?

dnolen19:09:00

that’s what I normally test with and I would be surprised if this was an issue that you wouldn’t see it there

jetzajac19:09:39

how do I run it?

jetzajac19:09:48

never tried it actually

jetzajac19:09:26

tried nodejs with lein, works fine. maybe it’s a boot to blame. or a browser. will try lein with browser

dnolen19:09:01

@jetzajac how is boot involved here?

dnolen19:09:19

or do mean you’re trying to use a build of master + boot or something?

jetzajac19:09:29

yep, this is what I do

jetzajac19:09:35

I just fixed a bug in cljs today

anmonteiro19:09:11

@jetzajac FWIW you can run ./script/noderepljs inside your CLJS repo which spawns a Node.js REPL with the changes you made

anmonteiro19:09:26

(i.e. no need to commit or specify ClojureScript versions)

dnolen20:09:10

right if you just want to fix a simple bug outside your app

jetzajac20:09:19

@dnolen do you want to commit my patch BTW? or should I sign something and attach to a ticket in jira?

jetzajac20:09:32

it’s as simple as 3 lines

dnolen20:09:41

@jetzajac please submit a CA and attach a ticket to JIRA please

dnolen20:09:50

we take many patches that are only 3 lines 😉

dnolen20:09:10

it would be nice if the patch included a test verifying the fix

jetzajac20:09:39

it is already there. ok, i’ll proceed with it

jetzajac20:09:33

@anmonteiro thanks! can’t see any problems with that repl

jetzajac20:09:26

here is the full stacktrace