Fork me on GitHub
#cljs-dev
<
2016-09-19
>
richiardiandrea01:09:17

Ok figured I needed to return different source based on the macros var for my test to work (it does not cover all the cases I have to admit).

dnolen12:09:35

@shaun-mahood like Clojure there’s no long term view beyond the stuff I mentioned in my talk and those things have been known for years. The process is primarily iterative and focused on baby steps.

dnolen12:09:50

@shaun-mahood people have repurposed the compiler for other targets - though that use case could probably be enhanced significantly (public APIs). Based on my experience with ClojureScript I would say just getting going on a new platform is probably a reasonable amount of work - and then there’s the multi-year long tail of making it work great.

dnolen13:09:21

probably time to split up the core tests 🙂

anmonteiro13:09:27

no problem, doing it now

anmonteiro13:09:07

@dnolen yea maybe we should start addressing that incrementally as new patches would need to add stuff to core-test?

dnolen13:09:37

if no one else gets to it, I’ll do this on Friday

anmonteiro13:09:10

thx for the heads up

shaun-mahood15:09:04

@dnolen: Makes sense, thanks.

anmonteiro16:09:32

@dnolen @mfikes I wonder if it should be possible for self-host to ignore :require-macros if: 1. we’re consuming code with :macros true in cljs.js and 2. the :require-macros refers to the current NS

anmonteiro16:09:45

I think this would solve the max stack exceeded error that we now have

anmonteiro16:09:15

and it would make possible to consume code which employs the “macro loop” pattern

anmonteiro16:09:08

I suspect that the analyzer would have to be aware that we’re consuming macro declarations in the :cljs branch, if it’s not already

anmonteiro22:09:29

@dnolen @mfikes FWIW, the following is working fine for me. It allows a single .cljc file that requires its own macros to work fine in Bootstrap! https://github.com/anmonteiro/clojurescript/commit/bde28d85a2a0846adbd4bf73e73f48b8dabbbfe8

anmonteiro22:09:40

worth capturing the above in a JIRA ticket?

dnolen22:09:45

@anmonteiro but the ticket needs some explication - I haven’t been following this one that closely

anmonteiro22:09:14

@dnolen it’s the problem we have in the om.next namespace that doesn’t allow it to be required in self host

anmonteiro22:09:39

because it requires its own macros, self-host ends up requiring itself over and over

dnolen22:09:58

ah right, OK, still a summary about the problem describing the minimal case will be useful

anmonteiro22:09:06

I can obviously add more context to the ticket

dnolen22:09:12

won’t be able to keep the context when I actually get around to looking at it

anmonteiro22:09:31

I’ve got a very minimal case that doesn’t work without the patch