This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2016-08-30
Channels
- # admin-announcements (1)
- # aws (32)
- # bangalore-clj (1)
- # beginners (2)
- # boot (137)
- # cider (2)
- # clara (1)
- # cljs-dev (39)
- # cljsrn (20)
- # clojure (268)
- # clojure-berlin (20)
- # clojure-canada (37)
- # clojure-dev (8)
- # clojure-gamedev (6)
- # clojure-norway (2)
- # clojure-russia (55)
- # clojure-spec (130)
- # clojure-uk (39)
- # clojurebridge (1)
- # clojurescript (102)
- # cursive (20)
- # datomic (231)
- # editors (5)
- # editors-rus (8)
- # events (5)
- # funcool (12)
- # hoplon (31)
- # instaparse (57)
- # jobs (9)
- # lein-figwheel (4)
- # off-topic (2)
- # om (8)
- # om-next (30)
- # onyx (241)
- # planck (6)
- # protorepl (4)
- # re-frame (115)
- # reagent (7)
- # rum (9)
- # schema (1)
- # test-check (9)
- # untangled (24)
- # yada (20)
@juhoteperi did you get far in your GCC bump patch?
I’m back from vacation now, so I could probably spend a few cycles trying to get that to work
@anmonteiro Haven't had much time to look since Saturday.
But at least one problem is that Compiler moduleLoader is set by parseFiles method: https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/Compiler.java#L1427
and we are not calling parse (which calls parseFiles)
and ProcessCommonJSModule calls CompilerInput getUri which requires that Compiler has moduleLoader: https://github.com/google/closure-compiler/blob/maven-v20160822/src/com/google/javascript/jscomp/CompilerInput.java#L395
@juhoteperi hrm pretty sure I got it to work just now
hmm interesting
I’ll attach a patch for your review
double-checking first by cleaning the build
I've been tinkering with this for some time and looks to me that convert-js-module would need quite refactor, but perhaps I'm completely off track
OK I must have had a cached build
looks like it’s failing, false alarm 🙂
I'll push my notes to github in few minutes
sure, thanks
https://github.com/clojure/clojurescript/compare/master...Deraen:cljs-1762?expand=1
Looks like we need to call Compiler .parse now instead of ProcessCommonJSModules .process
I'd like to start my first contribution to ClojureScript. are there any particular issues I can help out with? or should I just start looking here? http://dev.clojure.org/jira/browse/CLJS
@juhoteperi yeah, that was my first attempt
but parse will process all source-files etc. which causes problems
I got this:
ERROR: JSC_PARSE_ERROR. Parse error. primary expression expected at resources/public/js/libs/Circle.js line 6 : 7
that is because get-source-files returns a CompilerInput without the JSX processing
yeah, does it need to perform transforms earlier?
I’m going through your notes now
probably, unless there is some way to process single files like before
but I guess parsing has to be done to all files at once so that the moduleLoader can keep track of existing modules
@juhoteperi yeah but it didn’t previously, or did it?
@rads I think there are some CLJS issues in JIRA with the tag newbie
you could start there
found them: http://dev.clojure.org/jira/secure/IssueNavigator.jspa?mode=hide&requestId=10616
@anmonteiro There could be some reason why some new features require this, or maybe it is just implementation detail and they haven't though about projects using Closure as library
@juhoteperi spending a few more minutes with your notes looks like you’re on the right track
it looks to me that solving the js-transforms problem would give us an initial solution
trying that currently
although, and as you correctly noted, it would be n^2
n^2 with respect to the number of foreign deps
I wonder if ES6 modules can require CommonJS modules and other way round
And what about AMD & CommonJS
I’m not qualified to answer that question 😄