This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2016-08-27
Channels
- # admin-announcements (5)
- # cider (4)
- # cljs-dev (20)
- # cljsjs (2)
- # cljsrn (6)
- # clojure (126)
- # clojure-austin (2)
- # clojure-berlin (1)
- # clojure-brasil (5)
- # clojure-japan (1)
- # clojure-russia (14)
- # clojure-spec (2)
- # clojure-uk (3)
- # clojurescript (11)
- # cursive (19)
- # datomic (5)
- # editors (1)
- # emacs (10)
- # funcool (5)
- # hoplon (170)
- # instaparse (4)
- # jobs (1)
- # om (1)
- # onyx (1)
- # re-frame (14)
- # reagent (1)
- # testing (14)
- # yada (1)
@dnolen: @juhoteperi my conclusion was it would be easiest to just update 20160822 (the latest)
This would forcibly mean that we'd have to delete that checking code
Yeah, I agree that would be easiest
And I think we can remove all those can-convert-x?
vars and checks also
@anmonteiro Have you started with a patch to update to 20160822?
In any case, I did attach my patch to the issue
@juhoteperi: awesome, I did start to look into it but didn't have time to put a patch together
@juhoteperi: did you try compiling and running https://github.com/mneise/circle-color ?
Normally that's one indicator that modules compatibility didn't break
Ah, no. I was wondering if there was some project with which to test module processing.
@juhoteperi: i'm just asking because my first attempt to work on that patch broke that project
Yeah, it is broken 😞
@juhoteperi: this might be a good place to start looking for what would be needed for that to work
https://github.com/google/closure-compiler/commit/77805574dbdf21a5526b10a4c1fd866c0144dbba
I can't really help you a lot beyond that because I don't have access to a computer until Tuesday
Thanks, I already have some idea of the problem
@juhoteperi: cool, I'm curious what the problem is
ModuleLoader uses moduleRoots option, we are not setting, still checking if the default should work or if we need to set it
Aha, I was looking at wrong source for NPE
Compiler moduleLoader is null until Compiler parse is called