Clojurians
#cljs-dev
<
2016-08-27
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

anmonteiro06:08:27

@dnolen: @juhoteperi my conclusion was it would be easiest to just update 20160822 (the latest)

anmonteiro06:08:44

This would forcibly mean that we'd have to delete that checking code

juhoteperi08:08:46

Yeah, I agree that would be easiest

juhoteperi08:08:46

And I think we can remove all those can-convert-x? vars and checks also

juhoteperi09:08:55

@anmonteiro Have you started with a patch to update to 20160822?

juhoteperi09:08:16

In any case, I did attach my patch to the issue

anmonteiro09:08:48

@juhoteperi: awesome, I did start to look into it but didn't have time to put a patch together

anmonteiro09:08:01

@juhoteperi: did you try compiling and running https://github.com/mneise/circle-color ?

anmonteiro09:08:31

Normally that's one indicator that modules compatibility didn't break

juhoteperi09:08:38

Ah, no. I was wondering if there was some project with which to test module processing.

anmonteiro09:08:51

@juhoteperi: i'm just asking because my first attempt to work on that patch broke that project

juhoteperi09:08:54

Yeah, it is broken :disappointed:

anmonteiro10:08:57

@juhoteperi: this might be a good place to start looking for what would be needed for that to work

anmonteiro10:08:28

I can't really help you a lot beyond that because I don't have access to a computer until Tuesday

juhoteperi10:08:08

Thanks, I already have some idea of the problem

anmonteiro10:08:36

@juhoteperi: cool, I'm curious what the problem is

juhoteperi10:08:52

ModuleLoader uses moduleRoots option, we are not setting, still checking if the default should work or if we need to set it

juhoteperi11:08:49

Aha, I was looking at wrong source for NPE

juhoteperi11:08:09

Compiler moduleLoader is null until Compiler parse is called