Clojurians
#cljs-dev
<
2016-08-23
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

anmonteiro00:08:29

the way it is currently is we’re saving is-old and is-new

anmonteiro00:08:52

with 20160713, it’ll become incoherent: is-old = true, is-new = true

anmonteiro00:08:55

doesn’t make sense

anmonteiro00:08:14

I think the easiest would be to wait for 20160822 which has a substantial refactor of ES6ModuleLoader to ModuleLoader and just bump to that?

dnolen01:08:35

@anmonteiro I’m fine with waiting

favila16:08:40

@mfikes I wrote a patch to transit-java that I am curious if it resolves your parallel-build problems. If it doesn't it would disprove my hypothesis about separate containsKey()+get() being a problem. https://github.com/favila/transit-java/commit/3bb53013793b584496d61786c40a34bd0696065d

mfikes16:08:46

@favila I’ll give it a shot

mfikes17:08:43

@favila It ultimately failed in what I suspect is the same way. Here is a gist containing a transcript: https://gist.github.com/mfikes/97d9ab512e428a792f3932102a572dc2

favila17:08:00

@mfikes agreed, looks the same.

mfikes17:08:46

@favila FWIW, I was very careful to ensure I was testing with your patch, so I think the test above is valid.

favila17:08:33

@mfikes I guess it has to be something in WriteHandlerMap's mutation of the default handler that somehow doesn't get sychronized. Did you ever get a chance to try patch on http://dev.clojure.org/jira/browse/CLJS-1761 ? If it's still broken even with that, then I'm stumped.

favila17:08:38

@mfikes yes

mfikes17:08:41

@favila No. I’d have to actually comprehend what you wrote and apply that, which is more than I can afford to do at the moment. :disappointed: Perhaps later.

favila17:08:14

@mfikes Transit allows you to pre-create the handler map, when you do there is no handler cache involved. That is all the patch does: instead of read/write handlers only for custom types, creates handler map for all transit types ahead of time.

mfikes17:08:11

@favila Yeah, I’m sure it is a simple patch. I’m just unable to context switch right now.

favila17:08:27

@mfikes no problem, just giving some context

dnolen19:08:55

@rohit nice, I’m assuming that’s just the GWT compiled thing I was mentioning before

rohit19:08:02

I am guessing that as well. Its looks like a wrapper over closure-compiler

rohit19:08:50

I mean closure-compiler which works on js itself.