This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2016-08-22
Channels
- # admin-announcements (4)
- # bangalore-clj (1)
- # beginners (28)
- # boot (16)
- # clara (4)
- # cljs-dev (28)
- # cljsrn (63)
- # clojure (136)
- # clojure-berlin (7)
- # clojure-gamedev (1)
- # clojure-nl (4)
- # clojure-russia (47)
- # clojure-sg (8)
- # clojure-spec (39)
- # clojure-uk (132)
- # clojurescript (66)
- # clojurex (5)
- # clojutre (2)
- # code-reviews (14)
- # core-logic (1)
- # cursive (13)
- # datavis (1)
- # datomic (35)
- # dirac (1)
- # editors (1)
- # hoplon (46)
- # jobs (1)
- # lambdaisland (5)
- # lein-figwheel (1)
- # mount (10)
- # off-topic (3)
- # om (67)
- # onyx (54)
- # planck (7)
- # proton (15)
- # protorepl (1)
- # re-frame (174)
- # ring (4)
- # ring-swagger (3)
- # specter (14)
- # untangled (15)
I wonder how faster advanced compilation would become with this optimization in Closure Compiler https://github.com/google/closure-compiler/wiki/Releases#july-13-2016-v20160713
“much faster compilation, especially for projects with large files” sounds like the CLJS case
I wonder how much is “much faster” 🙂
@anmonteiro would be happy to see us bump Closure Compiler, there’s some ES6 related stuff that changed that I haven’t had time to look into
@dnolen last time I looked it would involve changing some constructor methods to Java Objects in cljs.closure
Happy to put a patch together for that. should I open a JIRA?
@anmonteiro yep go for it
@dnolen I’m wondering if I can remove these conditionals in the Closure Compiler patch https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/closure.clj#L79
it seems they’re no longer needed if we bundle the new versions of the GCC
FWIW, I’ve built a local version without them and tried it on https://github.com/mneise/circle-color
everything works as expected
@anmonteiro I’d rather leave those alone for now
https://github.com/google/closure-compiler/releases/tag/closure-compiler-parent-v20160822 includes the stuff needed for http://dev.clojure.org/jira/browse/CLJS-1755
@danielcompton that hasn’t been released yet on Maven
shouldn’t be long though
however, to upgrade the Closure Compiler to that release we’ll need to touch that code
so maybe I should stick with 20160713 for now?
well, actually 20160713 also has some changes to constructors that’ll make me have to touch that code
@dnolen yeah there’s just no way I can bump Closure without touching that code
reason is e.g. ES6ModuleLoader’s constructor in 20160713 is the same as what we infer as “old"
so I’ll wait for your instructions before proceeding any further
they had constructor A then refactored to B, so we had A = old and B = new. However, now they reverted back to A
@anmonteiro hrm this seems solveable via reflection no?
so we infer that constructor A is old and don’t provide functionality for some modules