Clojurians
#cljs-dev
<
2016-08-18
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

anmonteiro20:08:17

@dnolen: just a reminder that CLJS-1756 needs to be in place for the self-parity tests to run now

anmonteiro20:08:06

In case you forgot to add that one, I was just mentioning that to @mfikes

mfikes20:08:33

One thing I think would be amazing: If, for each patch attached to a JIRA, a CI system automatically checked to see if they apply, and if they pass for each major engine (perhaps on different OSs), while also covering bootstrap tests. (I suppose with each new commit, though, all of them would have to be re-executed, potentially leading to a kind-of quadratic complexity.)

rohit20:08:14

that’ll be awesome!!

anmonteiro20:08:53

Starting with just running the tests for master would be enough awesomeness

anmonteiro20:08:20

Then maybe we could add jira integration later

chris20:08:26

I have security concerns about applying/auto-testing patches from jira.

rohit20:08:51

For running the tests on CircleCI/Travis, all we would need to do is create a docker image with v8 engine at the minimum.

rohit20:08:28

@chris: agreed. maybe we can do that, once the ticket has reached a certain stage.

rohit20:08:03

Someone has already created a docker image with d8. https://github.com/shufo/docker-v8/blob/master/Dockerfile

mfikes20:08:30

Yeah to @chris 's point, checking CAs is a mechanical thing that could also be automated

dnolen21:08:00

@anmonteiro applied

dnolen21:08:07

let me know if anything else needs to get in

dnolen21:08:12

planning on cutting a release tomorrow

anmonteiro21:08:34

@dnolen hrm, this one is a direct port of a fix in Clojure: http://dev.clojure.org/jira/browse/CLJS-1751

anmonteiro21:08:15

and then there’s (probably low priority) one which solves a minor issue in REPLs http://dev.clojure.org/jira/browse/CLJS-1536

dnolen21:08:30

gonna skip that REPL one

dnolen21:08:40

I know it’s probably OK but we’ve had enough churn there recently

anmonteiro21:08:07

sounds reasonable :+1: