Fork me on GitHub
#cljs-dev
<
2016-07-31
>
anmonteiro22:07:10

I suspect that even if we make that a warning we’ll still see it in bootstrap CLJS which might be undesirable

anmonteiro22:07:02

I’m only now starting to look at what might be going wrong, but there should probably be a way around this

anmonteiro22:07:04

I also wonder if funky stuff will happen by using defmacro def in bootstrap

anmonteiro22:07:10

or any other special form, for that case

mfikes22:07:36

I can't recall if I tried the patch in regular ClojureScript—expanding the def macro would seemingly lead to a def def. Hmm...

anmonteiro22:07:21

proposal: don’t employ this check if we’re evaluating a form in a namespace that ends with $macros

anmonteiro22:07:35

(obviously) all tests pass if the above proposal is applied

mfikes23:07:12

proposal: def on a special form is legal, only triggering a warn. Introduce a mechanism to suppress warnings (à la :warnings) within specific scopes (perhaps via meta or set!), and then suppress it for (defmacro def instance in cljs.spec.

anmonteiro23:07:01

sounds more reasonable to me than what I proposed