Clojurians
#cljs-dev
<
2016-07-14
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

pat22:07:13

Using core.async in a bootstrap load-fn breaks derefing env/*compiler* during cljs.js/ns-side-effects. ana/missing-uses + check-uses et al are all already passed env as a parameter...swapping out each env/*compiler* with #?(:clj <@U095WMJNR>/*compiler* :cljs <@U095WMJNR>) in 6 lines fixes the issue and everything works as normal (from what I can tell). Can I submit a patch for this?

dnolen23:07:19

@pat would want to hear @mfikes opinion about that approach first

mfikes23:07:32

@pat I ended up doing a much heavier refactoring with Andare. Perhaps you’ve found a simpler set of changes. One thing you could do would be to run the core.async unit tests in a self-hosted environment to verify that your patch is sufficient. Feel free to copy Andare’s setup for this. See https://github.com/mfikes/andare/wiki