Fork me on GitHub
#cljs-dev
<
2016-06-27
>
dnolen00:06:15

@darwin ClojureScript requires 1.8.0 already

darwin10:06:47

@dnolen: some of my other tests revealed that the string/index-of usage is wrong anyways, it tests for -1 but it should test for nil instead

darwin10:06:05

it newly produces (invalid) urls with & in place of ?: https://gist.github.com/darwin/2082e63199d30a1c072bd0c2effac030

dnolen12:06:00

@darwin OK that’s a bug

dnolen12:06:46

thanks fixed in master

darwin12:06:14

looks good, thanks

bhauman20:06:16

And here is an initial spec for ClojureScript Compiler Options

bhauman20:06:18

https://gist.github.com/bhauman/2dca87815dfd92b3ff596bdc1e56c964 figured I share it, and save someone some typing in the future

bhauman20:06:09

It would be nice to attach the docs to the schema

bhauman20:06:35

via something like this

;; our own private registry for data on keys

(defonce ^:private registry-ref (atom {}))

(defn def-key-doc [k d]
  (swap! registry-ref assoc-in [k ::doc] d))

(defn key-doc [k]
  (get-in @registry-ref [k ::doc]))

bhauman20:06:31

and then perhaps generate documentation, and or provide docs on error

dnolen20:06:23

@bhauman: wow that’s awesome

bhauman22:06:42

It's probably smarter to just prefix everything into the ::cljs.schema namespace and handle any conflicts individually