This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2016-06-06
Channels
- # admin-announcements (1)
- # alda (2)
- # beginners (5)
- # boot (59)
- # clara (6)
- # cljs-dev (40)
- # cljsrn (32)
- # clojure (28)
- # clojure-austin (1)
- # clojure-belgium (67)
- # clojure-greece (60)
- # clojure-ireland (1)
- # clojure-japan (1)
- # clojure-russia (55)
- # clojure-spain (14)
- # clojure-spec (39)
- # clojure-uk (26)
- # clojurescript (152)
- # clojurewerkz (1)
- # cursive (21)
- # datomic (3)
- # dirac (15)
- # emacs (7)
- # events (2)
- # funcool (4)
- # hoplon (43)
- # immutant (1)
- # lambdaisland (1)
- # lein-figwheel (6)
- # leiningen (1)
- # off-topic (1)
- # om (23)
- # onyx (67)
- # other-languages (6)
- # pedestal (7)
- # planck (13)
- # proton (3)
- # protorepl (2)
- # re-frame (6)
- # reagent (5)
- # ring-swagger (6)
- # spacemacs (1)
- # specter (2)
- # yada (27)
@danielcompton: good point, I tried to look at figwheel’s implementation of the REPL integration, but didn’t see any logic related to this
but I didn’t spend much time on it, my main focus was investigation if dirac middleware could be integrated with figwheel’s nREPL mode
Would a patch to log a warning in dev mode when keywords were compared with identical?
be accepted?
@danielcompton: no there’s a real reason why it doesn’t work
@danielcompton: if you care about this particular one, you could implement it as another check in :sanity-hints of cljs-devtools, by monkey-patching cljs.core.identical_QMARK_
it already does some dirty monkey patching, and is not enabled by default for that reason, people have to explicitly enable it: https://github.com/binaryage/cljs-devtools/blob/master/src/devtools/sanity_hints.cljs
A side note, I’m playing with an idea to use source maps to map the "Cannot read property 'call' of null” type of errors back to original sources. And display it conveniently. That would be pretty nice I think.
@dnolen: I think sanity hints was pretty much what I was thinking of here
@danielcompton: we could add a warning if there is a inline literal but to completely honest this is not something I’m super interested in
sure, sanity hints would be as good a place to put it
what exactly is the problem with identical?
, I must admit I used to write identical?
for keyword checks
internally it’s only for the most perf critical stuff like the persistent data structures
ok, but could I make mistake that two keywords would have false reference check? (them being created independently somehow)
interesting, I would bet I was using identical?
on them successfully, and that was probably just a conicidence
so I think we should wanr about it in cljs-devtools, when people install :sanity-hints
warning about something people shouldn’t be doing doesn’t seem like a very useful warning IMO
but how should they know without understanding the internals? I used to use identical?
in wrong places and didn’t know. For me it was like === and I thought rest of cljs works well with it
btw. my route was javascript -> clojurescript, didn’t have chance to build that experience using more advanced tools in clojure land
I’m fine with higher level linters doing this kind of thing - less interested in ClojureScript getting involved in style linting