Clojurians
#cljs-dev
<
2016-05-31
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

bhauman15:05:04

The more I think about it the more I think it makes sense to have two more optional protocols for Repl envs to implement. ICompileException that has -caught for catching complile errors ICompileWarning that has a -warning for handling warnings These are directly analogous to IPrintStackTrace in that there is a lot of information that is better handled as data by the various ReplEnvs.

dnolen15:05:40

@bhauman: we could do that but if we can accomplish it without protocols, probably preferred

dnolen15:05:02

once you go the protocol route, then version mismatches cause real head aches as we’ve seen in the past

bhauman15:05:23

that is the truth

dnolen15:05:49

so my inclination is to figure out an extension point without protocols

bhauman15:05:04

:warning-handlers will meet my needs

bhauman15:05:37

then we'll have covered the bases

dnolen15:05:41

obviously less clean, but these days I prefer less version issues for users

bhauman15:05:47

absolutely

mfikes15:05:57

@dnolen: In the cljs.spec.test macro namespace there is a place where it refers to the speced-vars* helper function in the cljs.spec macro namespace, (rather than the speced-vars macro). This appears to cause issues that I’m wrapping my head around. I’ll let you know if I figure out anything concrete. But I thought I’d mention it since is appeared fishy for lack of a better technical term to describe it. Here’s the spot: https://github.com/clojure/clojurescript/blob/19510523ad9de3f16832d287bae86f701e8b4263/src/main/cljs/cljs/spec/test.cljc#L22

dnolen15:05:35

@mfikes: it’s probably not neccesary to use the call, if it simplifies to inline the macro I’m fine with that - patch welcome