Clojurians
#cljs-dev
<
2016-04-08
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

dnolen18:04:41

@nberger: reviewing your patch for CLJS-1614

dnolen18:04:10

perhaps I’m confused but it appears to do the opposite of what the patch description says?

dnolen18:04:29

when :restore is false it wrap the compiler environment in a new atom

nberger18:04:29

@dnolen let me see...

nberger18:04:37

ooops you are right :blush: it's the opposite :confused:

nberger18:04:46

sorry about that, do you want me to update the patch?

dnolen18:04:49

@nberger: for the new patch can we also follow the patch guidelines

dnolen18:04:08

@nberger: yes new patch welcome

nberger18:04:00

yes, will do

dnolen18:04:12

thanks much!

nberger18:04:51

@dnolen done

dnolen18:04:05

@nberger checking it out

dnolen18:04:19

@nberger: looks OK so far, have you tested this version of the patch on your own project?

dnolen18:04:26

I’m about to try it on some things

nberger18:04:02

yes, it works for me on reagent but also on my project that includes other stuff too (core.async, etc). Works ok in both cases

nberger18:04:32

Oh, sorry, this exact version I tested on reagent only :confused:, I'll test it on my project now

darwin18:04:10

off-topic: is there a way how to tell JIRA that my ticket has a patch, so the ticket appears under CLJS Screenable? I cannot create CLJS-NNNN.patch filename before I create a JIRA ticket, but then it does not allow me to change status of the ticket if I attach the patch later.

darwin18:04:26

I saw mfikes changing status of some of my JIRA tickets as having patch attached, but I didn’t find this switch in my JIRA interface

nberger18:04:23

works fine on my project too @dnolen

mfikes18:04:56

@darwin: Do you see an Edit button as the left-most button in the interface (essentially appearing under the rocket icon?) If not, probably just need to have permission added.

dnolen18:04:22

@nberger: seems OK over here in Om project

darwin18:04:45

@mfikes: thanks, no, I don’t have it there. I can just comment.

mfikes18:04:44

@dnolen Need to give @darwin access to JIRA when you have a spare moment.

dnolen18:04:02

@mfikes: sure I can do that now

dnolen19:04:04

@darwin: should be fixed now

darwin19:04:35

@dnolen: thanks, works for me now

dnolen19:04:35

@nberger: patch applied and pushed

nberger19:04:08

@dnolen woohoo, awesome! thanks! :simple_smile:

dnolen19:04:15

np thanks for the fix :simple_smile:

dnolen19:04:47

bumped tools.reader to 1.0.0-beta1 in master