Fork me on GitHub
#cljs-dev
<
2016-02-16
>
mfikes04:02:13

This documents a small experiment attempting to get proper file and line numbers when a cljs.test failure occurs. Curious if there are any thoughts: https://gist.github.com/mfikes/a043a4772a2bce65dfba

meow04:02:55

I think yer a slacker. 😉

mfikes04:02:13

Well, that qualifies as a thought. simple_smile

meow04:02:13

Oops. Totally OT

meow04:02:58

Should we call it good enough and head for a bar?

dnolen13:02:42

@mfikes: more accuracy in pin-pointing failures is welcome

mfikes13:02:28

@dnolen: yes. I think I'm going to see how clojure.test pulled that off

mfikes15:02:47

@dnolen: FWIW, Planck has been successfully using tools reader 1.0.0-alpha3 (it was in Planck 1.9, released about 4 weeks ago). Maybe ClojureScript could itself upgrade that dep (no rush—maybe after next ClojureScript release is out).

dnolen15:02:44

@mfikes yeah we can definitely bump that dep along with Google Closure - also need to bump Google Closure Library

mfikes15:02:20

@dnolen (Some things surrounding syntax quote would be fixed, and at least one corner case breaks: syntax-quote involving dot forms)

dnolen15:02:51

@mfikes: I see, thanks for the info

mfikes16:02:39

The syntax-quote for dot form issue I mentioned is captured http://dev.clojure.org/jira/browse/TRDR-34

mfikes17:02:54

So, something like this fixes the “syntax-quote of dot form” issue on the ClojureScript side: https://github.com/mfikes/clojurescript/commit/ffe8a81c8ae3d1b2008713518e2d8b3179127491