This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2016-02-15
Channels
- # aatree (23)
- # admin-announcements (13)
- # announcements (3)
- # beginners (49)
- # boot (50)
- # braid-chat (1)
- # braveandtrue (37)
- # cider (72)
- # cljs-dev (25)
- # cljsjs (6)
- # cljsrn (37)
- # clojure (78)
- # clojure-berlin (8)
- # clojure-greece (1)
- # clojure-ireland (2)
- # clojure-madison (14)
- # clojure-new-zealand (2)
- # clojure-poland (10)
- # clojure-russia (149)
- # clojured (2)
- # clojurescript (49)
- # community-development (6)
- # core-async (37)
- # cursive (1)
- # data-science (1)
- # datomic (30)
- # emacs (4)
- # euroclojure (1)
- # funcool (1)
- # graclj (1)
- # hoplon (17)
- # jobs (2)
- # jobs-rus (45)
- # ldnclj (6)
- # mount (12)
- # off-topic (124)
- # om (270)
- # onyx (131)
- # parinfer (70)
- # perun (2)
- # proton (168)
- # re-frame (32)
- # reagent (29)
- # ring-swagger (8)
- # testing (9)
- # yada (39)
@dnolen: so having modified every ISequential
type because of CLJS-744, I was left wondering if Eduction
shouldn't also implement IMeta
and IWithMeta
?
I suppose not, Clojure answered my question:
(with-meta (eduction (map inc) '(1 2 3)) {:a 1})
ClassCastException clojure.core.Eduction cannot be cast to clojure.lang.IObj clojure.core/with-meta--4375 (core.clj:217)
@dnolen, I am trying to re-apply with CLJS-1164
but I found a warning: WARNING: Use of undeclared Var cljs.core/apply at line 369 /home/kapitan/git/clojurescript/src/main/cljs/cljs/core.cljs
should I open an issue ?
I saw http://dev.clojure.org/jira/browse/CLJS-1411, adding a comment there
Patch cleaning 馃槃 http://dev.clojure.org/jira/browse/CLJS-1164
About http://dev.clojure.org/jira/browse/CLJS-744 should I just test it and change the status? it applies cleanly
Patch whitespace cleaning 馃檭 http://dev.clojure.org/jira/browse/CLJS-744
That's it for tonight
@richiardiandrea: I had to update the patch for CLJS-744, what did you do wrt. whitespace?
@richiardiandrea: I attached CLJS-744-2.patch to that issue
@anmonteiro: ah sorry I thought it was stale and just removed a not needed whitespace below Eductions
@richiardiandrea: I didn't update the patch because of what you did
I updated it because I found an edge case
I was only asking what the changes were so that I could apply them in the new patch
thanks. that's present in my updated patch as well, I'll update the ticket
@anmonteiro: not a big deal, but it was not applying cleanly with git am --keep-cr -s --ignore-whitespace < CLJS-744.patch
and I thought that was the problem, misunderstanding maybe 馃槃
another fairly straightforward ticket if anyone is interested http://dev.clojure.org/jira/browse/CLJS-1570
@anmonteiro: http://dev.clojure.org/jira/browse/CLJS-1569 needs rebasing on master whenever you get a chance
@dnolen: give me a few moments
@dnolen: done, assigned to you
@anmonteiro: thanks