Clojurians
#cljs-dev
<
2016-02-15
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

anmonteiro00:02:30

@dnolen: so having modified every ISequential type because of CLJS-744, I was left wondering if Eduction shouldn't also implement IMeta and IWithMeta?

anmonteiro00:02:59

I suppose not, Clojure answered my question:

(with-meta (eduction (map inc) '(1 2 3)) {:a 1})

ClassCastException clojure.core.Eduction cannot be cast to clojure.lang.IObj  clojure.core/with-meta--4375 (core.clj:217)

richiardiandrea02:02:49

@dnolen, I am trying to re-apply with CLJS-1164 but I found a warning: WARNING: Use of undeclared Var cljs.core/apply at line 369 /home/kapitan/git/clojurescript/src/main/cljs/cljs/core.cljs

richiardiandrea02:02:18

should I open an issue ?

richiardiandrea03:02:23

About http://dev.clojure.org/jira/browse/CLJS-744 should I just test it and change the status? it applies cleanly

richiardiandrea03:02:46

Patch whitespace cleaning :upside_down_face: http://dev.clojure.org/jira/browse/CLJS-744

richiardiandrea03:02:09

That's it for tonight :cljs:

anmonteiro12:02:18

@richiardiandrea: I had to update the patch for CLJS-744, what did you do wrt. whitespace?

anmonteiro12:02:12

@richiardiandrea: I attached CLJS-744-2.patch to that issue

richiardiandrea15:02:48

@anmonteiro: ah sorry I thought it was stale and just removed a not needed whitespace below Eductions

anmonteiro15:02:40

@richiardiandrea: I didn't update the patch because of what you did

anmonteiro15:02:50

I updated it because I found an edge case

anmonteiro15:02:03

I was only asking what the changes were so that I could apply them in the new patch

anmonteiro15:02:03

:stuck_out_tongue:

anmonteiro15:02:54

thanks. that's present in my updated patch as well, I'll update the ticket

richiardiandrea15:02:10

@anmonteiro: not a big deal, but it was not applying cleanly with git am --keep-cr -s --ignore-whitespace < CLJS-744.patch and I thought that was the problem, misunderstanding maybe :smile:

dnolen22:02:30

another fairly straightforward ticket if anyone is interested http://dev.clojure.org/jira/browse/CLJS-1570

dnolen22:02:48

@anmonteiro: http://dev.clojure.org/jira/browse/CLJS-1569 needs rebasing on master whenever you get a chance

anmonteiro22:02:48

@dnolen: give me a few moments

anmonteiro22:02:59

@dnolen: done, assigned to you

dnolen22:02:07

@anmonteiro: thanks