Clojurians
#cljs-dev
<
2016-01-07
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

kamn01:01:11

How relevant are CLJS-364 and 365 after 3+ years?

kamn03:01:18

Just going though open issues starting at oldest

kamn03:01:15

which seems to be related. The first possible solution needed to have the 20 array-seq but eventually another solution showed up that did not require that

kamn03:01:03

and I am not sure if cljs-364/5 is more of a nice to have at this point or a not needed

dnolen05:01:28

@kamn ah yeah those are still relevant - of course it’s an edge case that few people hit but I would like to see them addressed

maria08:01:29

It seems that when targeting nodejs and using advanced optimizations, command line arguments are not passed to the main function (http://stackoverflow.com/questions/34641241/clojurescript-nodejs-program-wont-accept-console-arguments). The reason is that process.argv is not included in the nodejs externs (https://github.com/clojure/clojurescript/blob/master/src/main/cljs/cljs/nodejs_externs.js), but we are using it in here: https://github.com/clojure/clojurescript/blob/master/src/main/cljs/cljs/nodejscli.cljs#L23. Should process.argv = {} be added to the node externs file or should users create their own externs file for this case?

dnolen14:01:03

@maria I think supporting the very basics makes sense - but we should try to communicate to users that the Node.js + advanced compilation combo isn’t really a recommended path. My suspicion is that the externs were there because in the early days it was not clear how much of a runtime performance benefit advanced gave.

dnolen15:01:48

I went ahead an updated the Node.js bits of Quick Start, hopefully that catches some people before they go down the wrong path

maria18:01:55

@dnolen: yeah, makes sense. Thank you for updating the wiki :simple_smile:

dnolen19:01:19

I’m thinking about cutting a new release tomorrow - if you have time to test master that would be great :simple_smile:

richiardiandrea19:01:37

@dnolen I can test using replumb too

richiardiandrea19:01:05

which release number? we also have outstanding tests we could try for some issue https://github.com/ScalaConsultants/replumb/labels/solved-upstream (just showing you the list)

dnolen19:01:51

@richiardiandrea: no release, you need to use ClojureScript from master by running ./script/build from the repo

richiardiandrea19:01:27

ah ok, I read you wanted to release, yes I contributed a patch + tests I am familiar with the process :smile: I will test against master

mfikes21:01:20

@dnolen: Current master is Go for Ambly/Natal, Replete, and Planck.

dnolen21:01:42

@mfikes: great thanks for the report

mfikes21:01:10

@richiardiandrea: May occur for Replumb as well, there is a breaking change wrt CLJS-1425 (`cljs.js/eval` callback value)

richiardiandrea21:01:59

Ok will check and change that