This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2015-12-07
Channels
- # admin-announcements (54)
- # announcements (1)
- # beginners (145)
- # boot (122)
- # cider (10)
- # cljs-dev (25)
- # cljsrn (20)
- # clojure (173)
- # clojure-art (4)
- # clojure-austria (1)
- # clojure-berlin (3)
- # clojure-germany (1)
- # clojure-nl (2)
- # clojure-russia (117)
- # clojure-switzerland (1)
- # clojure-uk (3)
- # clojurebridge (6)
- # clojurecup (36)
- # clojurescript (218)
- # clojurex (1)
- # core-typed (17)
- # cursive (23)
- # data-science (1)
- # datavis (2)
- # datomic (28)
- # emacs (3)
- # flambo (1)
- # hoplon (28)
- # ldnclj (19)
- # lein-figwheel (2)
- # leiningen (1)
- # luminus (1)
- # off-topic (1)
- # om (158)
- # portland-or (1)
- # re-frame (72)
- # reagent (48)
- # remote-jobs (1)
- # slack-help (7)
[Bootstrap] Arg! There is a typo in the keyword on [this line](https://github.com/clojure/clojurescript/blob/r1.7.189/src/main/cljs/cljs/js.cljs#L220) (intention was probably :macros-ns
) with a few consequences. When fixed, with other stuff, the compiled form of macro namespaces is cached.
In this experimental commit, I rippled through the result of where that fix should have an effect, with desired result for macro namespace caching then working in the Planck client of cljs.js
: https://github.com/mfikes/clojurescript/commit/51f991413ccc6807413cdc8e072b23e326da8e00
Above stuff captured in http://dev.clojure.org/jira/browse/CLJS-1504
I’ve seen that it is indeed possible for bootstrapped to properly cache in the case of a foo.core
(say, core.cljs
) namespace requires the macros in a foo.core
(say, core.clj
) namespace. In that case, both namespaces have the same name, but you want to cache the macros namespace with a different name. Without changing cljs.js
API, it can be done by peeking inside the cache data, which is less than ideal, but works. For example: https://github.com/mfikes/planck/blob/e34b62ebae24fb26cb4b17807b69506e3f860ba1/planck-cljs/src/planck/repl.cljs#L376-L378
Since it is difficult to discuss CLJS-1504 beyond the simple typo fix, I’ve attached a draft patch to it for comment. FWIW, this draft patch has been functioning pretty well for me.
@richiardiandrea has also been active in the self-host space… perhaps he can also help with downstream testing of the patch’s consequences
lool you did!
I will guys eventually test this as well, I am now concentrate to catch up with planck 😄
@richiardiandrea: Even if you simply build Replumb and run its tests using ClojureScript master at some point, I think that is valuable downstream validation.
yes true that
Now replumb is targeting 1.7.170
...I also have an issue that I would like to submit here, just want to be sure I am doing everything right 😄
Ok, let's see if it is a known problem-> https://github.com/ScalaConsultants/replumb/issues/56
@richiardiandrea: not a bug that’s how Google Closure works
oh ok, maybe then I just need planck
's patch for this...will try that
it was just odd that it is calling twice Loading dependencies for cljs.user
but maybe I will have to explore more the internals of ns
@richiardiandrea: I think it is this: https://github.com/clojure/clojurescript/wiki/Custom-REPLs#eliminating-loaded-libs-tracking
Ah beginners! Yes I knew I had a lot to learn, that's good I have good mentors 😄 Thanks Mike!