@mikethompson: is that :advanced?

No, that's :none

From a clean

ah from clean

Woah

👏:skin-tone-2: that's a big improvement!

if someone is interested in fixing cljs.compiler/requires-compilation? or cljs.analyzer/requires-analysis? I have some tips for things to look out for

makes for even faster builds if caching is reliable and you don't need lein clean

@dnolen: re 1.7.166. My bigger projects' tests pass. If I find time, I'll report any time improvements during the weekend.

@dnolen: tried 1.7.166 on my personal projects and all seems good. no problems with cljs.js or js module support 😉

similarly not having any issues after brief testing in multiple projects

@maria @bensu @martinklepsch awesome thanks for the reports

I tried with cljsbuild & figwheel SNAPSHOTs on my own projects and things worked well.

will just need to communicate the need to upgrade the tooling bits of user projects

so could use help on the various channels fielding the expected confusions

@dnolen: Will add a note to the lein-cljsbuild README to use the SNAPSHOT version or higher with 1.7.166 😉

@maria cool thanks

this is all great, so if no problems will do a release of master tomorrow morning EST

huge thanks to @juhoteperi for his patience on working and re-working the patch, it’s a huge long outstanding enhancement.

Thanks, happy to contribute

@dnolen: Hey David, just trying out 1.7.166 on my project that uses modules. I get an exception that one of my namespaces is not found. I have a directory called "modules" and in there are a couple of cljs files that are entry points for different pages. No other namespace depends on them. I load them on demand with the gclosure module manager. I think since those namespaces are not required by anything else so they don't get compiled. Shouldn't the compiler make sure they do get compiled when they are listed in the :entries key of the build spec?

@r0man: that’s an enhancement as far as I’m concerned

there was never any promise that would ever work

willing to take a patch for it, but that’s not in the realm of anything the original work was intended to support

this used to work with 0.0-3308 and I wonder what has changed

you just got lucky, that’s all

ok

didn’t write a single line of code with that use case in mind

plus it seems like something that’s easy to fix yourself by specifying those source directories in your build options

yes, maybe that's a bit of a special case. do people use the module manager to load modules?

yes people do

what do you mean by build options?

those dirs are under the source path

ah sorry I misunderstood what you were describing

@r0man: but now I understand even less what you are talking about

I don’t know why you aren’t defining a module for those entries

and if you have it should work

Hmm, I do define a module. I just can't see the entries beeing compiled

so your description of the issue was very misleading

come up with a minimal case

I'll try to make an example project ...

@dnolen Sorry, false alarm. I think I messed up my classpath. It works in the REPL, but not in my build script ...

@r0man: ok let me know if you can repro some other way

ok, will do.