Clojurians
#cljs-dev
<
2015-11-05
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

thheller07:11:47

@mikethompson: is that :advanced?

mikethompson07:11:51

No, that's :none

thheller07:11:25

ah from clean

martinklepsch09:11:01

:clap::skin-tone-2: that's a big improvement!

thheller09:11:42

if someone is interested in fixing cljs.compiler/requires-compilation? or cljs.analyzer/requires-analysis? I have some tips for things to look out for

thheller09:11:47

makes for even faster builds if caching is reliable and you don't need lein clean

bensu11:11:52

@dnolen: re 1.7.166. My bigger projects' tests pass. If I find time, I'll report any time improvements during the weekend.

maria12:11:56

@dnolen: tried 1.7.166 on my personal projects and all seems good. no problems with cljs.js or js module support :wink:

martinklepsch12:11:49

similarly not having any issues after brief testing in multiple projects

dnolen12:11:26

@maria @bensu @martinklepsch awesome thanks for the reports

dnolen12:11:58

I tried with cljsbuild & figwheel SNAPSHOTs on my own projects and things worked well.

dnolen12:11:15

will just need to communicate the need to upgrade the tooling bits of user projects

dnolen12:11:35

so could use help on the various channels fielding the expected confusions

maria12:11:49

@dnolen: Will add a note to the lein-cljsbuild README to use the SNAPSHOT version or higher with 1.7.166 :wink:

dnolen12:11:21

@maria cool thanks

dnolen12:11:32

this is all great, so if no problems will do a release of master tomorrow morning EST

dnolen12:11:14

huge thanks to @juhoteperi for his patience on working and re-working the patch, it’s a huge long outstanding enhancement.

juhoteperi17:11:48

Thanks, happy to contribute :simple_smile:

r0man18:11:59

@dnolen: Hey David, just trying out 1.7.166 on my project that uses modules. I get an exception that one of my namespaces is not found. I have a directory called "modules" and in there are a couple of cljs files that are entry points for different pages. No other namespace depends on them. I load them on demand with the gclosure module manager. I think since those namespaces are not required by anything else so they don't get compiled. Shouldn't the compiler make sure they do get compiled when they are listed in the :entries key of the build spec?

dnolen18:11:56

@r0man: that’s an enhancement as far as I’m concerned

dnolen18:11:03

there was never any promise that would ever work

dnolen18:11:32

willing to take a patch for it, but that’s not in the realm of anything the original work was intended to support

r0man18:11:36

this used to work with 0.0-3308 and I wonder what has changed

dnolen18:11:44

you just got lucky, that’s all

r0man18:11:48

ok :simple_smile:

dnolen18:11:06

didn’t write a single line of code with that use case in mind

dnolen18:11:20

plus it seems like something that’s easy to fix yourself by specifying those source directories in your build options

r0man18:11:32

yes, maybe that's a bit of a special case. do people use the module manager to load modules?

dnolen18:11:43

yes people do

r0man18:11:01

what do you mean by build options?

r0man18:11:15

those dirs are under the source path

dnolen18:11:23

ah sorry I misunderstood what you were describing

r0man18:11:46

:simple_smile:

dnolen18:11:57

@r0man: but now I understand even less what you are talking about

dnolen18:11:17

I don’t know why you aren’t defining a module for those entries

dnolen18:11:31

and if you have it should work

r0man18:11:03

Hmm, I do define a module. I just can't see the entries beeing compiled

dnolen18:11:31

so your description of the issue was very misleading :simple_smile:

dnolen18:11:39

come up with a minimal case

r0man18:11:50

I'll try to make an example project ...

r0man19:11:52

@dnolen Sorry, false alarm. I think I messed up my classpath. It works in the REPL, but not in my build script ...

dnolen19:11:32

@r0man: ok let me know if you can repro some other way

r0man19:11:57

ok, will do.