This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2015-11-04
Channels
- # admin-announcements (36)
- # beginners (54)
- # boot (74)
- # cider (14)
- # cljs-dev (91)
- # clojure (197)
- # clojure-austin (1)
- # clojure-conj (3)
- # clojure-india (5)
- # clojure-japan (3)
- # clojurescript (111)
- # core-logic (12)
- # cursive (6)
- # datascript (3)
- # datomic (16)
- # devcards (26)
- # events (1)
- # funcool (11)
- # hoplon (63)
- # jobs (2)
- # ldnclj (10)
- # lein-figwheel (6)
- # luminus (5)
- # nginx (7)
- # nyc (3)
- # off-topic (1)
- # om (148)
- # onyx (122)
- # portland-or (5)
- # re-frame (3)
- # reagent (25)
- # yada (15)
@anmonteiro: I fixed your permissions in JIRA, you should be able edit tickets now
@bhauman you’re not still using ns-dependents
are you? It’s going away - there’s just too many problems with it in larger projects
@dnolen I stopped doing it server side, I use the dependency graph on the client side
@juhoteperi’s patch rocks
should mean much faster build in complex projects and more sensible behavior all around
1.7.166 not working here
Note: this is on Windows <---
This same project compiles fine under 1.7.145 (albeit slowly)
@mikethompson: thanks for the check, will look into that probably something simple around paths
@mikepence: actually I don’t think this is a Windows thing
@mikethompson: I would install from master and verify the issue still exists
the List & Vectors cases were not being handled and your error looks the type of thing that occurs when you have missing methods
@dnolen: I'm stuck on the "install from master" instruction. Haven't done it before. Is it like a clojurescript library .... (1) checkout git repo? (2) lein install
?
script/build
is a shellscript (I'm on Windows)
either need to setup a bash env - or someone needs to port the build script to Windows
hrm I thought this was reasonable https://git-for-windows.github.io
I'll try but it will be quite a bit later tonight.
@dnolen: Great job with killing topo-sort and implementing find-sources for list&vector!
@dnolen: However, I am seeing a problem with require-compilation?
: cljs.core
is marked recompiled in each build and everything requires that, so everything is recompiled always
Simplest fix would be to never add cljs.core
to *recompiled*
@dnolen: not sure if i'm doing something wrong, but still not seeing any edit button
@juhoteperi: hrm I tested this yesterday and I didn’t see that behavior
@anmonteiro: should be fixed now
@juhoteperi: what optimization setting?
@juhoteperi: yeah I specifically tested that one
@dnolen: confirmed
@dnolen: Sorry for noise, seems to be boot-cljs specific
@juhoteperi: let me know if it’s not or if something about the changes makes fixing it for boot-cljs challenging
For some reason cljs/core.js.map doesn't get written by boot-cljs and requires-compilation will recompile ns if source-map doesn't exist
@juhoteperi: how are you seeing that it doesn’t get written?
By lookin at the output dir
I currently use boot-cljs 1.7.48-6 and 1.7.166 and there is a target/app.out/cljs/core.js.map
@juhoteperi: also in the tmp-dir passed as output-dir
@martinklepsch: Check latest boot-cljs master, I removed the old workaround
@juhoteperi: hm. I just pulled, build-jar
d and updated my build.boot and the js.map file is still being created in target as well as output-dir — I’m not sure if any of this is helpful, let me know if it isnt
@martinklepsch: Are re compilations also fast for you?
~650ms for 20lines of cljs with om.next dependency
@martinklepsch: I think I would the problem. Boot-cljs sets :source-map
to true
with :optimization :none
, as it should. But if :optimization
is not set boot-cljs sets :source-map
to source map file name which is only correct for advanced builds.
If you have set optimization none, it works fine.
let me try without any settings
@dnolen: I just tried, but failed, to run script/build
(under Windows) via git bash. Some failure to do with moving files about. I think I'm going to have to wait for the next release before I can test again.
@juhoteperi: hm. I just tried running bare boot watch cljs
and the .js.map file is still being created, no task options specified
@mikethompson: ok, the right solution in the long term is for people submit Windows build scripts
most of the build scripts are ridiculously simple and this would be a big improvement for a growing number of users
I can see what you mean about the build script being simple
Okay, in the meantime, I'll get one of my linux guys to try and replicate our issue on 1.7.166 and then try master. Will report back but not now until tomorrow (midnight here now)
@dnolen, I am also experiencing the same issue as @mikethompson with 1.7.166 release on OS X. creating a minimal case for it.
I did the build from master. It installed cljs v1.7.169 and I am still experiencing the same error.
@martinklepsch: Try enabling source-maps without explicitly setting optmizations
@juhoteperi: that’s it! super slow compilation, no js.map file
@juhoteperi: nice catch
@rohit: then make a minimal case. That means nothing involving 3rd party stuff - only the cljs.jar uberjar
if you can’t reproduce in this way then you will need to determine what interaction with the 3rd party thing is causing your problem and likely report it elsewhere.
@dnolen, sure. i suspect the issue maybe in lein-cljsbuild by looking at the stacktrace
@rohit: Try cljsbuild 1.1.1-SNAPSHOT
@juhoteperi, that fixed it. Thanks! 👍 🙏:skin-tone-4:
@dnolen: confirming that our project compiles with 1.7.166
(on Windows), now we have switched to the latest versions of tooling. Compile times:
17.145: 829 secs (old)
1.7.166: 69 secs (new)
There is much rejoicing here. Compile times were really starting to be a problem.