This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2015-10-21
Channels
- # admin-announcements (42)
- # alda (1)
- # beginners (11)
- # boot (24)
- # boulder-clojurians (2)
- # cider (10)
- # cljs-dev (23)
- # clojure (63)
- # clojure-czech (4)
- # clojure-japan (2)
- # clojure-russia (44)
- # clojure-sg (2)
- # clojure-switzerland (2)
- # clojurescript (135)
- # community-development (5)
- # css (4)
- # cursive (19)
- # datomic (34)
- # emacs (2)
- # events (5)
- # funcool (13)
- # hoplon (3)
- # ldnclj (43)
- # ldnproclodo (1)
- # lein-figwheel (7)
- # luminus (7)
- # off-topic (54)
- # om (115)
- # onyx (82)
- # overtone (3)
- # re-frame (6)
- # reagent (15)
- # yada (5)
@maria: I've already done some diagnosis. I'll write what I've found, attempt a patch, and then check with you if it still solves the original problem.
@bensu: Here is the minimal project I used to test the patch for CLJS-1467: https://github.com/mneise/main-optimizations-bug
@dnolen: tracking the CLJS-1472 regression I realize that the underlying cause is that cljs.closure/compile-file
is not true to its docstring: https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/closure.clj#L424
it says it either writes to output-file
or returns a string, but it might also write to output-to
.
I'd recommend removing the output-to
fallback case, since it is correct only for one file, and leads to unexpected behavior
before this change https://github.com/clojure/clojurescript/commit/a4d6a241cd9d45bf0356809c18df14585befd68f
I'm looking around and it looks like there is one other needed change, in build
so that when the output-to
file is compiled, the output-file
is correctly set.
(also, that file assumes that the given output-file
/`output-to` is a relative path which may not be but that's another issue)
@dnolen: @maria patch ready for review http://dev.clojure.org/jira/browse/CLJS-1472
Updated the docstring to
"Reads the first object from a PushbackReader. Returns the object read.
If EOF, throws if eof-is-error is true. Otherwise returns sentinel.
Only supports edn (similar to clojure.edn/read)ā
http://dev.clojure.org/jira/browse/CLJS-1475What do people think about enabling JIRA integration for this channel? Might be a cool way to surface activity etc.
@martinklepsch: Itās a great idea I think, unfortunately at the moment we have hit slackās integration limit. I will speak to the fellow admins and prune some out