Clojurians
#cljs-dev
<
2015-10-21
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

maria00:10:45

@bensu: Oh, did one of them break something?

maria08:10:26

@bensu: I assume you are already at it? Happy to work on this though if not :wink:

bensu08:10:39

@maria: I've already done some diagnosis. I'll write what I've found, attempt a patch, and then check with you if it still solves the original problem.

maria08:10:58

@bensu: Here is the minimal project I used to test the patch for CLJS-1467: https://github.com/mneise/main-optimizations-bug

bensu08:10:52

thanks, I'll try it there

bensu14:10:25

@dnolen: tracking the CLJS-1472 regression I realize that the underlying cause is that cljs.closure/compile-file is not true to its docstring: https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/closure.clj#L424

bensu14:10:51

it says it either writes to output-file or returns a string, but it might also write to output-to.

bensu14:10:01

I'd recommend removing the output-to fallback case, since it is correct only for one file, and leads to unexpected behavior

dnolen14:10:43

but what’s the output-to assessment? This must be used in various places

bensu14:10:39

it was unreachable

bensu14:10:16

after that it became reachable but undesirable

dnolen14:10:20

but what I’m asking is by removing it do we break other things?

bensu14:10:17

I'm looking around and it looks like there is one other needed change, in build so that when the output-to file is compiled, the output-file is correctly set.

bensu14:10:09

(also, that file assumes that the given output-file/`output-to` is a relative path which may not be but that's another issue)

bensu15:10:19

@dnolen: @maria patch ready for review http://dev.clojure.org/jira/browse/CLJS-1472

bensu15:10:56

since it is not the usual one-line fix I tried to be extra verbose on the rationale

dnolen16:10:38

@bensu thanks

martinklepsch16:10:40

Updated the docstring to

"Reads the first object from a PushbackReader. Returns the object read.
 If EOF, throws if eof-is-error is true. Otherwise returns sentinel.

 Only supports edn (similar to clojure.edn/read)”
http://dev.clojure.org/jira/browse/CLJS-1475

dnolen17:10:25

looks good

martinklepsch18:10:42

What do people think about enabling JIRA integration for this channel? Might be a cool way to surface activity etc.

gjnoonan18:10:15

@martinklepsch: It’s a great idea I think, unfortunately at the moment we have hit slack’s integration limit. I will speak to the fellow admins and prune some out