another newbie friendly JIRA issue http://dev.clojure.org/jira/browse/CLJS-1393

@dnolen: wondering how goog-define could/should handle metadata? declare doesn’t allow metadata right?

@martinklepsch: you should try it, I don’t see why it wouldn’t.

(declare ^{:my-meta true} my-var) — I tried this and meta returns nil

@martinklepsch: did you try in Clojure?

yeah and http://clojurescript.net

probably should try proper cljs as well?

@martinklepsch: yeah I would not use any bootstrapped thing yet as any source of reference

@martinklepsch: http://dev.clojure.org/jira/browse/CLJS-1395

so it seems like goog-define needs to emit a comment w/o a trailing semi-colon

@dnolen: ugh. I saw that one before but failed to check if js* emits a ;

@martinklepsch: the issue is not js*, it’s just the JS expression/statement handling logic

@martinklepsch: see cljs.compiler/emit-wrap

it will just emit the trailing semi

all we need to do is check if we’re emitting an :op of type :js where the content of what we’re about to emit starts with /*

we could be more general, but I really don’t see the benefit of that - no one should be using js* anyway

we don’t care if people using js* get broken at all

ok, I think I see it

@dnolen: If you haven’t already done it I can try myself at a patch

@martinklepsch: not working on it, go for it!

@martinklepsch: this is the life of a ClojureScript compiler hacker :stuck_out_tongue:

@dnolen: probably not a now-thing but maybe its a good idea to deprecate the ^{:jsdoc “@define”} at some point?

@martinklepsch: there’s nothing to deprecate ^{:jsdoc …} has other uses

sure. more thinking about the 20 lines that are cljs.compiler/get-define

@martinklepsch: ah, maybe … we rarely “deprecate” anything a la Clojure

preferred to just have docs point to the right new thing

yeah was just thinking out loud. deleting some code always feels good :wink:

yeah deleting is good if we’re making something simpler

but deleting an existing feature is unlikely

so, wrt building master on windows...

it's actually not too bad in the end, but the current wiki page can send people down dead ends (afaict) that consume countless hours of pain

i typed some notes...: https://www.refheap.com/107799

i don't know java. i took a total stab in the dark here, and it worked: https://www.refheap.com/107799#L-25

no idea why

before doing that, ./script/build failed w/: https://www.refheap.com/107824

@dnolen: attached a patch

@martinklepsch: thanks!

@jackjames: if you could clean up the Windows instructions page that would be very helpful

@jackjames: -cp syntax is definitely different on Windows

@dnolen: any possibility of a solution that would make it possible to build from master on windows w/out modifying source (script) files?

@jackjames: I don’t see how if the -cp syntax is different

not sure either, but possibly detecting windows there similarly to the code just above for detecting hudson?

@jackjames: would take script/build.bat

if there’s a reasonable way to detect windows sure

this is outside of anything I know (or want to know about)

happy to take a patch if someone else sorts it out though of course

tbh, i'd really prefer not to do the wiki-editing. apologies; it's just not something i feel comfortable doing at this point. hopefully my notes can help someone who wishes to volunteer for that...

@jackjames: I'll give it a shot if no one else is up for it, there's not too many Windows cljs developers so I'm happy you did the leg work.

great. happy to assist in any other way that i can...lmk if you need anything tested or have any questions

@jackjames: Will do