cljdoc

hlship 2024-03-27T19:54:10.131939Z

Is there anything special I need to do to enable table markup in my docstrings? I updated org.clj-commons/pretty but the tables didn't render correctly: https://cljdoc.org/d/org.clj-commons/pretty/2.4.0/api/clj-commons.ansi#compose

hlship 2024-03-27T19:54:46.456649Z

I haven't had a chance to set up a local cljdocs image.

hlship 2024-03-27T19:55:13.862049Z

The terms:

Characteristic   | Values
--               |--
foreground color | `red` or `bright-red` (for each color)
background color |  same as foreground color
boldness         | `bold`, `faint`, or `plain`
italics          | `italic` or `roman`
inverse          | `inverse` or `normal`
underline        | `underlined` or `not-underlined`

e.g.
should be valid table syntax, no?

2024-03-27T20:02:27.704629Z

i think you need the left and right edges too

2024-03-27T20:02:38.439479Z

| Enabled by default | Version Added | Version Updated |
| ------------------ | ------------- | --------------- |
| true               | 0.1           | 0.1             |
is what works in #splint, tho i don't think you need the full dashes across

hlship 2024-03-27T20:45:13.281729Z

I was using https://markdownlivepreview.com/ to compose my docstrings, but it supports a slightly different table syntax. It looked https://github.com/vsch/flexmark-java?tab=readme-ov-file like I could omit the leading/trailing pipes on each line, but perhaps that's an option that cljdoc doesn't enable?

hlship 2024-03-27T21:30:45.864439Z

Do we know whether cljdoc/cljdoc docker image works correctly on OS X w/ M1? Seems to get as far as:

WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
Preparing heap dump dir
and then nothing.

hlship 2024-03-27T21:31:07.992529Z

I does create the heapdumps directory.

hlship 2024-03-27T21:55:11.196909Z

Not having a lot of luck with the cljdoc/cljdoc-check-action either.

hlship 2024-03-27T21:59:12.234199Z

https://github.com/clj-commons/pretty/actions/runs/8459138409/job/23174878780?pr=115 ... looks like my build doesn't put the pom file where cljdoc expects it. I'll see about that soon.

hlship 2024-03-27T23:06:29.724579Z

There must be at least three hyphens in each column of the header row.. That's probably what's screwed up!

hlship 2024-03-27T23:14:56.866529Z

Advice for getting cljdoc to build org.clj-commons/pretty snapshot again? I'm basically pushing snapshots to see if it builds correctly.

hlship 2024-03-27T23:16:04.391339Z

Joy! With three dashs, even Codox's markdown generator recognizes it as a table.

🎉 1
hlship 2024-03-27T23:34:04.469539Z

But I'm still trying to figure out how to get cljdocs to rebuild for my latest 2.5.0-SNAPSHOT

lread 2024-03-27T23:39:04.302459Z

Wow @hlship, you are in a flurry of cljdoc activity today! simple_smile

hlship 2024-03-27T23:39:32.715479Z

Yes, it's been nagging me.

lread 2024-03-27T23:39:55.257879Z

For markdown in docstrings cljdoc's intent is to stick to the GitHub flavored markdown variant.

lread 2024-03-27T23:41:31.743769Z

Apologies for the cljdoc check action, it was added but nobody has stepped up to maintain it. So I think it might be a bit stale. I remember you asking about it ages ago... I never got around to giving it some love.

lread 2024-03-27T23:45:39.855979Z

I've never tried the cldoc docker image from macOS on an M1. I do have access to an M1 MacBook, I could try sometime my-tomorrow.

lread 2024-03-28T00:15:44.798509Z

Ok, tomorrow came early! I reproduced your reported issue when running the docker image from an M1 Mac. Then, I retried but added the --platform linux/amd64 option to my docker run cmd for cljdoc, and it seems to work fine.

hlship 2024-03-28T00:16:11.106619Z

Nice; I'll give that a try later.

hlship 2024-03-28T00:16:52.371279Z

I threw caution to the wind, pushed my changes, and released pretty 2.5.0 and the table formatting is chef_kiss

lread 2024-03-28T00:17:49.748439Z

You maverick! simple_smile Glad it worked out for you!