Fork me on GitHub
#cljdoc
<
2023-06-09
>
juhoteperi13:06:04

Aha it was repl code in a namespace what wasn't correctly commented and is already removed in master

lread13:06:38

Hi @U061V0GG2! All good? Or is there something you'd like me to look into on the cljdoc side?

juhoteperi14:06:02

Yeah I found the reason. Due to Reitit multimodule setup it just took a while to find the correct place for the logs.

juhoteperi14:06:50

I might add the check github action to catch these cases earlier

lread14:06:17

Coolio, glad you are sorted out. It's on my todo list to freshen up the github check action, but not sure when I'll get to it.

juhoteperi14:06:34

And hmm, does cljdoc always default to the latest version even if that is a alpha?

lread14:06:59

Yeah, think so, are you seeing something different?

juhoteperi14:06:25

No but I was wondering it could be safer to show the latest non-alpha & non-snapshot

juhoteperi14:06:35

Or link to both from our readme

lread14:06:45

snapshots are treated differently

lread14:06:20

But I think cljdoc doesn't currently categorize beyond snapshot non-snapshot.

lread14:06:51

Interesting idea to explore though. Feel free to raise an issue.

juhoteperi13:06:42

I pushed a new Reitit version, clicking on build just for the main package didn't trigger build for the modules so API docs is empty. Are the other modules built automatically later? I'm not sure how this has worked before.

juhoteperi13:06:47

Now I see reitit-core job on circleci, I didn't trigger that myself at least

lread14:06:49

Hi @U061V0GG2! Here are https://github.com/cljdoc/cljdoc/blob/master/doc/userguide/for-library-authors.adoc#module-support (notice, even, the mention of Reitit!). I think I could add a few words maybe. Cljdoc will try to build docs for all jars published to clojars with no special consideration for modules (for the build aspect). So the complete docset for a library with modules will lag a bit as cljdoc builds the docs for modules.

juhoteperi14:06:33

oh I read the first line "every 60 seconds" and then wondered why is it taking longer... next line says it is running jobs every 10 minutes

lread14:06:16

If you want/need to have the builds trigger sooner, you can always trigger the builds yourself.

lread14:06:02

I often do that as part of my release flow, https://github.com/clj-commons/rewrite-clj/blob/fe3d880c1ccea5724d5048d3735de859ee235515/script/ci_publish.clj#L54-L67. For Reitit, you'd have to trigger a build for each submodule jar.