Fork me on GitHub
#cljdoc
<
2023-03-10
>
serioga16:03:12

hm, I think that I saw value of the :added metadata in documentation. But I don't see this now. Am I glitching?

lread16:03:45

Hi @U0HJNJWJH, cljdoc does not currently show added metadata, it does show deprecated metadata. It treats it as a boolean. Example:

serioga16:03:14

But I have a memory of light grey ADDED label under function name...

lread17:03:18

Not sure, maybe it did once? Could you be thinking of some codox generated docs? https://weavejester.github.io/medley/medley.core.html#var-deep-merge:

serioga17:03:39

Ah, maybe another documentation system...

lread17:03:00

Could be! My brain is foggy on this too. If cljdoc did start to show :added it would have to show the value, and for consistency, we'd like also show the value of :deprecated.

💯 2
lread17:03:09

I'm pretty sure we collect and save :added during API analysis.

lread17:03:30

Given cljdoc's sparse design aesthetic, I'm guessing :added was omitted in the spirit avoiding visual clutter. But if it is considered generally useful info we should consider including it.

serioga17:03:37

If author adds this information then author think that this info is useful :-)

lread17:03:07

Yep, all trade-offs ui minimalism vs info. For example the fact that a function is deprecated is more important than what version it was deprecated, hence cljdoc just showing "deprecated" (if I understand the design choice correctly). And deprecation is typically much more important to a user of a library than what version a var was added. I personally don't have a preference on this one. If @U050TNB9F has a free moment, he might chime in.

serioga17:03:53

I feel like you mean that ADDED conflicts with DEPRECATED but I don't understand why :-)

serioga17:03:16

Deprecated is important, there is no standard for it's value afaik (but I would not mind see non-boolean value as well). Also it would be cool to show deprecated vars as striked-out in the sidebar's navigation (including namespaces).

lread17:03:09

> I feel like you mean that ADDED conflicts with DEPRECATED but I don't understand why :-) Nope, just trying to convey that DEPRECATED is probably more important information than ADDED for users of a library. > Also it would be cool to show deprecated vars as striked-out in the sidebar's navigation (including namespaces) Ya, I too was thinking some indication of deprecation would be nice in index views.

lread14:03:26

Also @U02N27RK69K is very often helpful with ui design trade-offs. She might, if she has time, chime in (absolutely no pressure Cora, I expect you are busy these days).

Cora (she/her)17:03:54

people come to docs to see what they can use and how they can use it and so deprecated is more important to know about than added. that said, it's not obvious how to get the right version of docs for a library (you click/tap the version at the top to pick different versions) and so looking at the latest docs it may be useful to see added. you won't also see "removed", though, so that's of limited utility

Cora (she/her)17:03:01

I think well-done UI can show added and not feel cluttered. we could also improve how versions are selected

Cora (she/her)17:03:38

there will always be a tension between what the cljdoc team thinks people need to see and what authors would like them to see, unfortunately. I like the idea of showing added, I sometimes find it helpful context, like a git blame but in the code

lread18:03:08

thanks @U02N27RK69K, much appreciated

2
martinklepsch20:03:27

we’ve been talking about semantic diffs (based on analysis data) and effectively using that to see changes between library versions.

martinklepsch20:03:51

don’t see anything wrong with supporting some representation of :added though