Fork me on GitHub
#cljdoc
<
2023-01-13
>
lread19:01:48

I am happy to take a look in a bit @UEENNMX0T

👍 2
Noah Bogart19:01:04

No worries, there's no rush

lread20:01:58

Ah.. ok. The malli lib is not specifying any minimum Clojure version, when cljdoc doesn't see a version specified it currently defaults to 1.10.1, but malli uses :as-alias which requires 1.11. So easy fix, I think. I'll just have cljdoc default to 1.11.1 when it sees no Clojure version. I shall make it so and report back when done.

👍 2
Noah Bogart20:01:23

Fantastic, thank you so much for looking into that

lread20:01:50

My pleasure!

lread21:01:16

Currently wrestling with the mundanity of getting cljdoc-analyzer to build again after CircleCI breach.

lread22:01:14

Ah. Looks like somebody deleted some deploy keys and did not recreate them. (it was me!).

😂 2
lread22:01:55

Ok. Finally back in business. Released new version of cljdoc-analyzer and I rebuilt https://cljdoc.org/d/metosin/malli/0.10.0, all looks good to me.

lread22:01:19

Thanks for raising this @UEENNMX0T, much appreciated!

🎉 2
pithyless17:01:27

> Ah.. ok. The malli lib is not specifying any minimum Clojure version, when cljdoc doesn't see a version specified it currently defaults to 1.10.1, but malli uses :as-alias which requires 1.11. How should a lib specify a min-version of Clojure for cljdoc? malli does have this in deps.edn:

org.clojure/clojure {:mvn/version "1.11.1"}

lread20:01:31

Thanks for asking @U05476190! TL;DR: I don't think malli needs any adjustment here. Cljdoc only looks at jars so it only sees poms. The https://repo.clojars.org/metosin/malli/0.10.0/malli-0.10.0.pom for malli does not include a org.clojure/clojure dep. I'm not sure if it is best practice for a lib to specify a minimum Clojure version as a dep, but it seems like a reasonable thing to do. I do so for https://repo.clojars.org/rewrite-clj/rewrite-clj/1.1.45/rewrite-clj-1.1.45.pom, which has support for Clojure >= 1.8.0. That all said: • this doesn't cover ClojureScript which you don't want to explicitly include as a dep for a cljc lib. For rewrite-clj, for example, I document that I support the current version of ClojureScript only. • even if malli specified Clojure 1.11.1 in the pom, Clojure analysis would have passed but ClojureScript analysis would have failed because cljdoc was defaulting to a 1.10.x version of ClojureScript • I think cljdoc should default to the current releases of Clojure and ClojureScript (which it is now doing)

pithyless06:01:32

Thanks for clarifying! BTW, in case you missed it on #malli - this particular issue was fixed and malli is 1.10 compatible again. https://github.com/metosin/malli/pull/816

lread14:01:09

Ah, cool thanks for sharing. I'm selfishly glad malli was temporarily bound to Clojure 1.11+. It helped to find a problem in cljdoc! simple_smile