cljdoc

lread 2022-05-16T13:46:50.099809Z

@corasaurus-hex docset search has been working great! After much use I think https://github.com/cljdoc/cljdoc/issues/630.

Cora (she/her) 2022-05-16T13:49:26.228309Z

oh weird

lread 2022-05-16T13:50:41.961119Z

Stop words, eh? Generally handy but sometimes also not what you want.

Cora (she/her) 2022-05-16T13:51:11.880469Z

I'm guessing "and" would be missing, too

Cora (she/her) 2022-05-16T13:51:15.282319Z

fun

lread 2022-05-16T13:53:40.916999Z

One approach is to just disable stop words. Probably (?) ok for our docset search.

Cora (she/her) 2022-05-16T13:54:18.307029Z

it seems like we'd have to do that

lread 2022-05-16T13:55:13.158729Z

I think maybe yeah. The word the is typically unimportant. But who knows, maybe it is a var name in some lib.

Cora (she/her) 2022-05-16T13:55:19.736029Z

even if you just disabled stopwords for the var/ns name you'd then miss those words in the rest of the docs

Cora (she/her) 2022-05-16T13:55:44.561359Z

I guess if we could remove the names of all ns/var from stopwords that might be enough?

lread 2022-05-16T13:56:06.684529Z

Yeah, was just about to type that idea!

Cora (she/her) 2022-05-16T13:56:10.636119Z

I'm not sure the search library we're using supports that

Cora (she/her) 2022-05-16T13:56:15.100719Z

but it's a neat idea

lread 2022-05-16T13:56:49.981229Z

I’m glad we simultaneously thought of it!

lread 2022-05-16T13:57:07.982249Z

But the brute force disabling all stop words would likely be ok too.

Cora (she/her) 2022-05-16T13:57:14.170249Z

great minds!! ☺️

1
lread 2022-05-16T13:58:19.525799Z

FWIW, I don’t have stop words enabled for server side search. But I’m searching small fields though. The only blobby thing I am searching is the pom description.

Cora (she/her) 2022-05-16T13:59:07.420559Z

http://elasticlunr.com/docs/stop_word_filter.js.html

Cora (she/her) 2022-05-16T13:59:55.168579Z

seems like something we can customize

lread 2022-05-16T14:00:23.472519Z

excellent!

Cora (she/her) 2022-05-16T14:01:05.516909Z

if you have time then feel free. I might be able to look at it later today at some point

Cora (she/her) 2022-05-16T14:01:16.155549Z

😍 1
Cora (she/her) 2022-05-16T14:01:20.830339Z

we just got a new kitten though

lread 2022-05-16T14:01:29.275789Z

Purrty!

Cora (she/her) 2022-05-16T14:01:37.064819Z

so i'm pretty busy 😻

lread 2022-05-16T14:02:07.327459Z

That’s awesome, nice to have a little furball friend

lread 2022-05-16T14:03:17.452869Z

Yeah I might look at it. I have been busy with eatoin these last few days. So many projects, so little time!

Cora (she/her) 2022-05-16T14:03:19.902859Z

this is number 3. we lost two cats over the past year (one was old age and the other heart failure 😞) so it seemed a good time to introduce a new little one

Cora (she/her) 2022-05-16T14:03:25.927339Z

kk!

lread 2022-05-16T14:03:44.032419Z

Does cat have name yet?

Cora (she/her) 2022-05-16T14:04:07.736269Z

cheese 😹

lread 2022-05-16T14:04:25.843089Z

Oh that’s good! Love it!

Cora (she/her) 2022-05-16T14:04:40.581329Z

gosh you're prolific with what you work on

Cora (she/her) 2022-05-16T14:04:47.178649Z

I wish I had that energy

lread 2022-05-16T14:07:42.007069Z

I thought you did! At least it looks like you do from over here! I seem to be hyper-focused on one thing until I get distracted by the next thing. Believe it or not, I was only looking at etaoin to fix our cljdoc README contributor badges to look good in a dark mode theme (need transparent backgrounds). And then… well… I’m now a maintainer on etaoin.

Cora (she/her) 2022-05-16T14:44:20.411089Z

lol collecting maintenance work like a katamari

lread 2022-05-16T14:58:34.966109Z

Awesome projects need my love, it seems!

lread 2022-05-16T15:06:05.695439Z

I think I’ll tackle the stopwords issue @corasaurus-hex, I need a small break from eatoin. Gonna just start with just entirely disabling them, if that works for you too.

Cora (she/her) 2022-05-16T15:07:52.190879Z

cooooool!

Cora (she/her) 2022-05-16T15:07:54.413529Z

well

Cora (she/her) 2022-05-16T15:08:03.415179Z

it's probably fine

Cora (she/her) 2022-05-16T15:08:32.644379Z

I don't much like it but it'll work

lread 2022-05-16T15:09:52.497689Z

Maybe you are right… So if I search for the we’ll likely match all docs (if I disable stopwords entirely).

Cora (she/her) 2022-05-16T15:12:53.482229Z

yeah

Cora (she/her) 2022-05-16T15:12:57.599449Z

I think I know how to fix it

Cora (she/her) 2022-05-16T15:12:58.695689Z

stand by

lread 2022-05-16T15:13:19.258979Z

If we refine… If I search for which in babashka.fs it should probably match which in everything because docs might be talking about which too.

Cora (she/her) 2022-05-16T15:15:03.777119Z

yep

Cora (she/her) 2022-05-16T15:15:06.909679Z

but those should be few

Cora (she/her) 2022-05-16T15:15:11.434489Z

I'm working on the fix now

lread 2022-05-16T15:15:29.824469Z

I would think so.

lread 2022-05-16T15:15:45.956259Z

Cool, thanks!

Cora (she/her) 2022-05-16T15:36:13.589539Z

https://github.com/cljdoc/cljdoc/pull/631

Cora (she/her) 2022-05-16T15:36:16.333359Z

I haven't tested it

Cora (she/her) 2022-05-16T15:36:20.988569Z

I have a couple meetings right now

lread 2022-05-16T16:00:24.236519Z

nice small change!

Cora (she/her) 2022-05-16T16:03:01.988089Z

the nice part about js in the browser is that even when they do silly things like use global values it only affects the one browser context if you make changes to the globals

Cora (she/her) 2022-05-16T16:03:10.661219Z

next page load it's gone

lread 2022-05-16T16:04:34.072139Z

the kitty litter box is automatically cleaned!