Fork me on GitHub
#cljdoc
<
2022-05-16
>
lread13:05:50

@corasaurus-hex docset search has been working great! After much use I think https://github.com/cljdoc/cljdoc/issues/630.

lread13:05:41

Stop words, eh? Generally handy but sometimes also not what you want.

Cora (she/her)13:05:11

I'm guessing "and" would be missing, too

lread13:05:40

One approach is to just disable stop words. Probably (?) ok for our docset search.

Cora (she/her)13:05:18

it seems like we'd have to do that

lread13:05:13

I think maybe yeah. The word the is typically unimportant. But who knows, maybe it is a var name in some lib.

Cora (she/her)13:05:19

even if you just disabled stopwords for the var/ns name you'd then miss those words in the rest of the docs

Cora (she/her)13:05:44

I guess if we could remove the names of all ns/var from stopwords that might be enough?

lread13:05:06

Yeah, was just about to type that idea!

Cora (she/her)13:05:10

I'm not sure the search library we're using supports that

Cora (she/her)13:05:15

but it's a neat idea

lread13:05:49

I’m glad we simultaneously thought of it!

lread13:05:07

But the brute force disabling all stop words would likely be ok too.

Cora (she/her)13:05:14

great minds!! ☺️

simple_smile 1
lread13:05:19

FWIW, I don’t have stop words enabled for server side search. But I’m searching small fields though. The only blobby thing I am searching is the pom description.

Cora (she/her)13:05:55

seems like something we can customize

lread14:05:23

excellent!

Cora (she/her)14:05:05

if you have time then feel free. I might be able to look at it later today at some point

Cora (she/her)14:05:20

we just got a new kitten though

Cora (she/her)14:05:37

so i'm pretty busy 😻

lread14:05:07

That’s awesome, nice to have a little furball friend

lread14:05:17

Yeah I might look at it. I have been busy with eatoin these last few days. So many projects, so little time!

Cora (she/her)14:05:19

this is number 3. we lost two cats over the past year (one was old age and the other heart failure 😞) so it seemed a good time to introduce a new little one

lread14:05:44

Does cat have name yet?

lread14:05:25

Oh that’s good! Love it!

Cora (she/her)14:05:40

gosh you're prolific with what you work on

Cora (she/her)14:05:47

I wish I had that energy

lread14:05:42

I thought you did! At least it looks like you do from over here! I seem to be hyper-focused on one thing until I get distracted by the next thing. Believe it or not, I was only looking at etaoin to fix our cljdoc README contributor badges to look good in a dark mode theme (need transparent backgrounds). And then… well… I’m now a maintainer on etaoin.

Cora (she/her)14:05:20

lol collecting maintenance work like a katamari

lread14:05:34

Awesome projects need my love, it seems!

lread15:05:05

I think I’ll tackle the stopwords issue @corasaurus-hex, I need a small break from eatoin. Gonna just start with just entirely disabling them, if that works for you too.

Cora (she/her)15:05:03

it's probably fine

Cora (she/her)15:05:32

I don't much like it but it'll work

lread15:05:52

Maybe you are right… So if I search for the we’ll likely match all docs (if I disable stopwords entirely).

Cora (she/her)15:05:57

I think I know how to fix it

lread15:05:19

If we refine… If I search for which in babashka.fs it should probably match which in everything because docs might be talking about which too.

Cora (she/her)15:05:06

but those should be few

Cora (she/her)15:05:11

I'm working on the fix now

lread15:05:29

I would think so.

lread15:05:45

Cool, thanks!

Cora (she/her)15:05:16

I haven't tested it

Cora (she/her)15:05:20

I have a couple meetings right now

lread16:05:24

nice small change!

Cora (she/her)16:05:01

the nice part about js in the browser is that even when they do silly things like use global values it only affects the one browser context if you make changes to the globals

Cora (she/her)16:05:10

next page load it's gone

lread16:05:34

the kitty litter box is automatically cleaned!