@corasaurus-hex docset search has been working great! After much use I think https://github.com/cljdoc/cljdoc/issues/630.
oh weird
Stop words, eh? Generally handy but sometimes also not what you want.
I'm guessing "and" would be missing, too
fun
One approach is to just disable stop words. Probably (?) ok for our docset search.
it seems like we'd have to do that
I think maybe yeah. The word the is typically unimportant. But who knows, maybe it is a var name in some lib.
even if you just disabled stopwords for the var/ns name you'd then miss those words in the rest of the docs
I guess if we could remove the names of all ns/var from stopwords that might be enough?
Yeah, was just about to type that idea!
I'm not sure the search library we're using supports that
but it's a neat idea
I’m glad we simultaneously thought of it!
But the brute force disabling all stop words would likely be ok too.
great minds!! ☺️
FWIW, I don’t have stop words enabled for server side search. But I’m searching small fields though. The only blobby thing I am searching is the pom description.
seems like something we can customize
excellent!
if you have time then feel free. I might be able to look at it later today at some point
we just got a new kitten though
Purrty!
so i'm pretty busy 😻
That’s awesome, nice to have a little furball friend
Yeah I might look at it. I have been busy with eatoin these last few days. So many projects, so little time!
this is number 3. we lost two cats over the past year (one was old age and the other heart failure 😞) so it seemed a good time to introduce a new little one
kk!
Does cat have name yet?
cheese 😹
Oh that’s good! Love it!
gosh you're prolific with what you work on
I wish I had that energy
I thought you did! At least it looks like you do from over here! I seem to be hyper-focused on one thing until I get distracted by the next thing. Believe it or not, I was only looking at etaoin to fix our cljdoc README contributor badges to look good in a dark mode theme (need transparent backgrounds). And then… well… I’m now a maintainer on etaoin.
lol collecting maintenance work like a katamari
Awesome projects need my love, it seems!
I think I’ll tackle the stopwords issue @corasaurus-hex, I need a small break from eatoin. Gonna just start with just entirely disabling them, if that works for you too.
cooooool!
well
it's probably fine
I don't much like it but it'll work
Maybe you are right… So if I search for the we’ll likely match all docs (if I disable stopwords entirely).
yeah
I think I know how to fix it
stand by
If we refine… If I search for which in babashka.fs it should probably match which in everything because docs might be talking about which too.
yep
but those should be few
I'm working on the fix now
I would think so.
Cool, thanks!
I haven't tested it
I have a couple meetings right now
nice small change!
the nice part about js in the browser is that even when they do silly things like use global values it only affects the one browser context if you make changes to the globals
next page load it's gone
the kitty litter box is automatically cleaned!