oof, type errors

maybe I'll do the work of rewriting these using functional components

oof, this is all tangled

Oof, if only I understood TypeScript! Does that cause us problems? Can we catch these types of errors at build time and fail the build?

it doesn't right now but it's something we should fix

things are a bit tangled but it's nothing that can't be fixed

or put in the work to switch to cljs

I will defer to you on all things client-side, but I certainly would not object to a switch to cljs someday. That said, if TypeScript is a better fit and/or preferred, that’s absolutely cool too.

I'd like to learn some more cljs and it might be fun

I was also thinking we might be able to use sci to make it so certain libraries could be tried in the browser

Now live: Searching within a single library now breaks down results for articles by section headings. Looking good to me, let us know if you see any issues! Thanks to @corasaurus-hex for encouraging me to dive in on this one (it is just a small change atop all the hard work done by her!).

is it worth crafting an announcement?

Well… there are rules for #announcements… and their frequency. But we can noisy as we like in #releases.

ahhh ok

I think(?) the rule of thumb was that if you can still see your #announcements announcement then don’t post a new one. But now that we have full Slack history… that rule no longer makes sense. Can’t remember where this spelled out… somewhere…

Oh description on #announcements sez “Please keep them occasional”.

I’ll post the news in #releases

oof, tapping on mobile is broken because of loss of focus. i'll need to fix that

Good catch! And related: Would be interesting to know, some sort of usage stats. Like what percentage of folks come in from mobile.

gah, all search clicks are broken

oof

@lee I'm just going to commit this to master so it ships quicker

❯ git diff HEAD
diff --git a/js/single-docset-search.tsx b/js/single-docset-search.tsx
index 7461755..81113ed 100644
--- a/js/single-docset-search.tsx
+++ b/js/single-docset-search.tsx
@@ -485,9 +485,6 @@ const SingleDocsetSearch = (props: { url: string }) => {
             onBlur={(event: FocusEvent) => {
               const input = event.target as HTMLInputElement;
               input.classList.toggle("b--blue");
-              if (showResults) {
-                setShowResults(false);
-              }
             }}
             onKeyDown={(event: KeyboardEvent) => {
               const input = event.target as HTMLInputElement;

Sure!

can't believe I broke it 😬

Yeah, but the important thing is you noticed and you fixed it! 🎉

@lee https://github.com/cljdoc/cljdoc/pull/618/files

pretty sure that fixes all the things

Awesome!