Fork me on GitHub
#cljdoc
<
2021-10-13
>
rickmoynihan14:10:27

Does anyone have any ideas why I’m getting build failures for releases like this: https://cljdoc.org/builds/49563

rickmoynihan14:10:58

Am I doing something wrong?

lread14:10:40

@rickmoynihan, the double v on the version looks very suspicious:

rickmoynihan14:10:28

@lee: that was on a later build. i.e. I added it because I thought the lack of a v in the git tag might be causing it

rickmoynihan14:10:52

but I got the same error with or without.

rickmoynihan14:10:17

the build I pasted above is for the preceding one 0.1.4

lread14:10:54

Ah. Good to know. I’ll take a quick peek and see what I can see.

rickmoynihan14:10:35

One difference is that the jars here have been built and deployed with the new tools.build stack

rickmoynihan15:10:09

does the process assume a git tag is created? Because the tools.build deploys don’t seem to tag or push tags — I created them manually later, but I think before triggering a build in cljdoc

lread15:10:21

There is something confused about the version tag… cljdoc did find your README so it is successfully reaching back to your repo… (It finds your repo via scm info in the from the deployed pom on clojars)…

rickmoynihan15:10:38

ahh so it expects pom.xml in the repo to be correct? Rather than just a template for tools.build

lread15:10:39

Oh wait…

rickmoynihan15:10:43

ah ok I just fixed that locally

rickmoynihan15:10:20

repl out of sync

rickmoynihan15:10:54

I really need to add some tests to this project; to help catch this sort of thing, unfortunately the project I forked it from had none

rickmoynihan15:10:28

I’m still getting a similar error https://cljdoc.org/builds/49570 - but can’t seem to find the job on circle

rickmoynihan15:10:08

@lee hmm still having problems :thinking_face:

lread15:10:07

Ah snapshot builds. Haven’t tried those yet myself with cljdoc. But… the build log is simply telling you that tag v0.1.7-SNAPSHOT does not exist in your repo.

rickmoynihan15:10:17

I seem to recall it working much better in the past with leiningen projects — Does tools.build do less of things that you rely on?

lread16:10:56

I’ve tried tools.build on a couple of projects and found it worked fine for me. I’m not a lein guy though. But I expect tools.build gives you more control and therefore you have to be more explicit.

rickmoynihan15:10:33

can you rerun a build?

lread15:10:56

Yep. There is a wee hidden rebuild button you will barely see if you hover over it.

👍 1
lread15:10:45

So leiningen probably fills the pom scm tag with the git sha. Which might be more appropriate for a snapshot build?

rickmoynihan15:10:27

yeah — is the pom taken from clojars or the git repo?

rickmoynihan15:10:48

I’m assuming the jar

rickmoynihan16:10:00

@lee: hmm still getting the issue — this time I’ve changed the build process to create the version and tag, and push them before deploying to clojars. So the tag exists but I get this error: https://cljdoc.org/builds/49576

rickmoynihan16:10:45

I don’t prefix the tags with v but when I did that earlier it ended up looking for tags prefixed with vv

lread16:10:09

@rickmoynihan this must be driving you slightly barmy! simple_smile

rickmoynihan16:10:30

😆 only slightly

rickmoynihan16:10:26

I probably shouldn’t have started shaving this yak… They’re always hairier than you expect! 😆

rickmoynihan16:10:10

.. and then you realise you need to oil your clippers ✂️

😂 1
lread16:10:43

I successfully deployed and built docs for rewrite-clj recently… lets compare with that.

rickmoynihan16:10:24

I will need to finish for the day in a few minutes btw

lread16:10:29

Ok the url in my docs on rewrite-clj contains no v prefix for the version: https://cljdoc.org/d/rewrite-clj/rewrite-clj/1.0.699-alpha/doc/readme

👍 1
lread16:10:16

My git repo tags do include the v prefix https://github.com/clj-commons/rewrite-clj/tags

rickmoynihan17:10:45

ahh I think that’s what’s different — my tag and scm tag don’t quite match

rickmoynihan17:10:13

I’m using sean corfields tools build wrapper (mainly because it came with the project template)

rickmoynihan17:10:21

and I think it sets this for you

lread17:10:13

Sean’s build helper tool looks interesting but I wanted to feel tools.build raw first.

rickmoynihan17:10:03

Yeah — I was planning on going that way too — but just ran with what the template gave me

lread17:10:19

Makes sense

rickmoynihan17:10:19

it came from deps-new

lread17:10:36

I sense impending extreme cljdoc success coming for dogstatsd…

lread17:10:11

If you get tripped up on any further issues, you know where to find us!

rickmoynihan17:10:00

Thanks for your help! 🙇

lread18:10:05

Congrats! The yak is shaved! yak🪒🎉

seancorfield18:10:49

Per the build-clj README: • jar • Requires: :lib and :version, • :target, :class-dir, :basis, :resource-dirs, :scm, :src-dirs, `:tag` (defaults to (str "v" version)), :jar-file, (my emphasis)