Fork me on GitHub
#cljdoc
<
2021-06-11
>
seancorfield10:06:23

Thank you, @U050TNB9F — what was the resolution here?

martinklepsch10:06:43

Not running cljs analysis :)

martinklepsch10:06:59

Not the best of solutions but best I can offer for now :)

seancorfield10:06:21

I mean, is it hardcoded or does it just try, fail, and ignore?

martinklepsch10:06:41

It’s hardcoded

seancorfield10:06:52

Thank you. And “sorry” 🙂

martinklepsch10:06:01

We should fail separately but that’s kind of a long standing improvement

martinklepsch10:06:37

You’re welcome! Eager to support people making such exemplary use of cljdoc

😊 3
martinklepsch09:06:23

@mrkiouak I also don’t have a good answer to why recur isn’t working there. Could you extend the test suite here and then maybe someone can take a look? https://github.com/cljdoc/cljdoc-analyzer/blob/a8334e4405c3f5657a981ab5189db0038ecd034a/test/integration/cljdoc_analyzer/cljdoc_main_shell_test.clj#L156

rkiouak15:06:55

Will take a look at this. In parallel, is https://github.com/protojure/lib/blob/master/src/protojure/internal/grpc/codec/io.clj#L5 the appropriate metadata to have added to try to prevent this file from being scanned? the most recent scan https://app.circleci.com/pipelines/github/cljdoc/builder/20050/workflows/d1b47500-b9e5-40e7-bb42-dc1cdf994953/jobs/36425 with this metadata annotation seems to have had no effect...

martinklepsch15:06:18

Unfortunately the metadata does not prevent the file from being required so it still has to be possible to load it

adamtait16:06:19

Hi friends! I had a build that failed (https://cljdoc.org/builds/45381). I’ve fixed the reason that it failed. How do I re-run it?

martinklepsch16:06:01

There’s a hidden rebuild button in the top right (left of the GitHub link)

adamtait16:06:56

ah. so there is! (… edits HTML in browser …)

adamtait16:06:20

&gt; Everything is looking splendid! Thanks @U050TNB9F 🙂

martinklepsch22:06:59

you’re welcome 🙂