Fork me on GitHub
#cljdoc
<
2021-05-24
>
Joshua Suskalo16:05:02

Today I put up this PR, which includes the code change needed to fix this issue. I still haven't updated the tests for it yet, but it's a start. https://github.com/cljdoc/cljdoc-analyzer/pull/40

🙌 6
Joshua Suskalo19:05:20

So with this PR now merged, how long should I have to wait before I can rebuild the documentation for farolero?

lread19:05:22

Congrats @suskeyhose! Someone just needs to update cljdoc to point to your change in cljdoc-analyzer. Technically I think you have the power, but this is your first commit, so we shall help. @martinklepsch I see you merged @suskeyhose’s cljdoc-analyzer change, are you in progress in making it live? If you are busy, lemme know and I can do.

martinklepsch19:05:19

I’m not in front of my computer right now but could do it tomorrow:)

Joshua Suskalo19:05:03

Alright, that makes sense.

lread19:05:23

I can do now… I’ll test local and then push. Letcha know when done.

lread20:05:40

Am experiencing what seem to be local technical difficulties in testing (I don’t think there is anything wrong with your change). Will ping back.

Joshua Suskalo20:05:43

Thanks for the heads up

lread20:05:46

The technical problem was squarely between my ears. Have pushed change to cljdoc and it should automatically deploy after build/test.

Joshua Suskalo20:05:13

Awesome, thanks for the quick turnaround on this!

lread20:05:21

Happened to be available, so happy to help.

lread20:05:41

Ok your change is live!

lread20:05:42

Feel free to hit the hidden rebuild link to force a rebuild of your docs.

Joshua Suskalo20:05:11

Thanks! It worked like a charm. 🙂

lread20:05:07

Awesome, thanks for the fix!

Joshua Suskalo20:05:43

No problem! I hope to contribute more in future if I see any more issues.

lread21:05:03

That’s great! Welcome aboard!