Fork me on GitHub
#cljdoc
<
2021-04-13
>
lread18:04:06

@martinklepsch, when you have a moment: I’m updating cljdoc to use clojure 10. This includes moving to the new cli syntax. I see a some scripts that might now be unused? If so, I’d rather delete them than update them. • https://github.com/cljdoc/cljdoc/blob/master/script/deploy-jar.sh I do see some deploys to clojars in the past…. is this something that we want to do? Was this to get cljdoc docs into cljdoc? • https://github.com/cljdoc/cljdoc/blob/master/script/serve.shhttps://github.com/cljdoc/cljdoc/blob/master/script/trigger-circle-analysis.sh Ok to delete these guys?

martinklepsch19:04:03

The serve one can definitely be deleted, that one is like veeeeerrryyy old 😄

martinklepsch19:04:23

the trigger circle ci analysis can probably also go

martinklepsch19:04:46

deploying cljdoc to clojars would still be nice to get cljdoc on cljdoc but I haven’t updated it there in a long time

lread19:04:06

Coolio, tx! I will keep deploy-jar.sh, we could always add this step CI someday.

lread20:04:22

Huh. I think cljdoc analysis job is actually using JDK11 now (I could simply be out of the loop, I thought we were still on JDK8). We only specify an image of circleci/clojure:tools-deps in the https://github.com/cljdoc/builder/blob/56a713989e29398e8a36a02c3d405299dd8d9cc2/.circleci/config.yml#L12. I guess they moved to JDK11.

docker run -i -t circleci/clojure:tools-deps
$ clojure -Sdescribe
{:version "1.10.3.822"
 :config-files ["/usr/local/lib/clojure/deps.edn" "/home/circleci/.clojure/deps.edn" ]
 :config-user "/home/circleci/.clojure/deps.edn"
 :config-project "deps.edn"
 :install-dir "/usr/local/lib/clojure"
 :config-dir "/home/circleci/.clojure"
 :cache-dir "/home/circleci/.clojure/.cpcache"
 :force false
 :repro false
 :main-aliases ""
 :repl-aliases ""}
$ java -version
openjdk version "11.0.10" 2021-01-19
OpenJDK Runtime Environment 18.9 (build 11.0.10+9)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.10+9, mixed mode, sharing)
I guess we should be more specific in for our docker image. Maybe circleci/openjdk-8-tools-deps or circleci/openjdk-11-tools-deps depending on what we want.