Fork me on GitHub
#cljdoc
<
2020-09-28
>
lread16:09:02

Hello cljdoc dev team! I have finally resubmitted my url fixups PR as https://github.com/cljdoc/cljdoc/pull/415 and am looking for a review. @martinklepsch I think you are busy these days, is there anyone else who typically helps with reviews?

martinklepsch16:09:44

I’ll try to give this a review this week, besides me there’s a few other people in this channel and watching the repo that might weigh in 🙂

lread16:09:26

Awesome, thanks! I’d love to get some eyes on this and get some feedback.

lread12:09:43

Thanks so much for reviewing! I will have a look shortly! 🙂

martinklepsch12:09:53

My pleasure, looks really great overall

lread20:09:43

Thanks again for your thoughtful review, I’ve gone over all of your comments. Please feel free to close (or we can discuss further) the ones I have left open.

lread20:09:40

Sweet! GitHub “Rebase and merge” is not possible due to conflicts… is that odd or normal? “Merge pull request” is available though.

martinklepsch21:09:34

If you don’t mind please rebase locally and then merge using “Merge pull request”

martinklepsch21:09:10

IMHO that’s the best way to merge PRs since it doesn’t create interleaving histories and you still have a clear merge commit / branching point

lread21:09:30

Sounds good, tx, will do.

lread22:09:05

ok merged! Hope you didn’t mean to imply I should squash, ’cause I did no squashing!

martinklepsch11:10:55

Nope, having the commits is perfect :)

martinklepsch11:10:06

Thank you 🙏

lread13:10:06

And thank you @martinklepsch! A pleasant and fruitful interaction, as usual! simple_smile

martinklepsch13:10:03

Absolutely ☺️ in fact I told a friend about how friendly and pleasant open source can be sometimes :)

lread15:10:06

I find the Clojure community to be smart, kind, patient and thoughtful. A real nice group!

lread17:09:25

Someone setup of a clone of icon.now.sh here’s a PR to use it: https://github.com/cljdoc/cljdoc/pull/416

🚀 6
lread17:09:10

@martinklepsch or anybody else, any objections with a merge to master?

martinklepsch17:09:18

amazing! go for it!