Fork me on GitHub
#cljdoc
<
2019-11-01
>
Jakub Holý (HolyJak)12:11:47

update: fixed (on master, not sure whether/when it will be deployed automatically) @martinklepsch Search is broken, the backend obviously returns EDN instead of JSON, even though the response header reads content-type: application/json. I am looking into it. The problem is here:

(cond-> context
                        (nil? (get-in context [:response :headers "Content-Type"]))
                        (update-in [:response] coerce-to content-type transformer'))
- we did set Content-Type for the search and thus coerce-to is not triggered to transform the EDN to JSON. I guess the right thing is to not set the response type (we are lying now: we say json but send EDN) and let the negotation (with only json allowed) to figure it out. I will push a fix to master ASAP. But we should check that we don't have the same problem elsewhere...

4
martinklepsch12:11:45

Oh, interesting. I’ve tried curl with the proper Accept header and it also returns EDN…

Jakub Holý (HolyJak)12:11:59

fix is on master. Will it autodeploy?

Jakub Holý (HolyJak)12:11:09

The header does not help - we used to set Content-Type at the bottom of the interceptor stack together with Clojure data. The cond-> above then just skips converting the data and they only get stringified.

martinklepsch12:11:35

It will autodeploy, yes

martinklepsch12:11:28

Your fix looks good, I like how the stuff you did with coerce-body makes the code more concise there

martinklepsch13:11:31

Oh and regarding deployment: each commit should have a tickmark/orange circle/red cross indicating CI/CD status

👍 4
dominicm21:11:22

I followed https://github.com/cljdoc/cljdoc/blob/master/doc/userguide/faq.md#how-do-i-set-scm-info-for-my-project and copied the <scm> in the pom.xml and replace laforge99 with SevereOverfl0w and aatree with high. I'm getting issues still https://cljdoc.org/builds/21487

dominicm21:11:08

What's the simplest way for me to try and run a build locally (including git import) I've done 5 releases so far debugging this 😄

dominicm21:11:31

oh derp. I hadn't pushed yet before building.

dominicm21:11:41

read the error Dominic 🙂

dominicm21:11:01

Where's the rebuild button?

schmee21:11:06

@dominicm it is hidden in the top right next to “SCM”

dominicm21:11:09

oh I found it

dominicm21:11:13

that's literally invisible

dominicm21:11:37

https://cljdoc.org/d/io.dominic/high/0.9.0/doc/readme still marked as failing, even though that worked

seancorfield21:11:03

Hah, I didn't even know you could force a rebuild!

seancorfield21:11:25

I wonder if that was there when I was having similar problems before?

dominicm21:11:47

I had to read the source, then inspect the source

martinklepsch22:11:34

It’s been there for a looooong time

martinklepsch22:11:03

@dominicm there’s docs on how to run builds locally. Check the guide for library authors for a link to that