Fork me on GitHub
#cljdoc
<
2019-04-14
>
lilactown17:04:58

hey ya’ll. really impressed with cljdoc. having some issues with a lib I’d like to have on here

martinklepsch17:04:15

I literally just saw the failing build 🙂

lilactown17:04:25

it’s a CLJS lib that depends on React

lilactown17:04:40

would it help to provide externs?

martinklepsch17:04:04

Unfortunately I don't have a good answer to this problem currently. cljdoc's analysis builds on the jar/pom only.

lilactown17:04:05

I could maybe include cljsjs/react. I’d prefer to allow the consumer to include React however they see fit

martinklepsch17:04:40

Maybe there's a way we can tell the CLJS analyzer to silently ignore string requires, I think that should work (those always refer to npm stuff right?)

martinklepsch17:04:33

I'll start a thread in #cljs-dev

👍 1
martinklepsch17:04:01

Hope somebody gets what I'm trying to say 😄

lilactown17:04:15

I can try and help clarify if people have questions

lilactown17:04:51

I wonder how shadow-cljs does the analysis

martinklepsch17:04:07

It looks at node_modules and creates some input for the analyzer based on that.

martinklepsch18:04:31

But we don't know what node_modules should look like since we only look at the pom.xml

martinklepsch18:04:33

In a sense a library like clinch doesn't perfectly declare it's dependencies because react is sort of coming out of another package manager

martinklepsch18:04:07

Would be interesting to see how this problem could be solved in general but I guess it hasn't been too much of an issue so far

thheller19:04:44

@martinklepsch I created an example not too long ago that showed how to deal with string requires easily. I can't remember where I put it though.

thheller19:04:04

I posted it here and you asked me to create a PR which I forgot 😛

martinklepsch19:04:15

Now that you say it this rings a bell! I’ll try do look that up in the logs next weekend after Clojure/north. @lilactown if you want to open an issue against cljdoc that would be great, then we can’t forget (as I apparently did before :D)