Fork me on GitHub
#cljdoc
<
2019-01-31
>
martinklepsch14:01:16

I’ve done some work on opening up what types of articles can be supported and would appreciate some feedback on the approach: https://github.com/cljdoc/cljdoc/pull/262

Avichal19:02:57

@U050TNB9F Looks good to me. Just a bit worried about (require ns) in system.clj for external namespaces. But since everything will run in CircleCI I don’t think we need to worry about it?

martinklepsch19:02:56

What makes you worried about this?

martinklepsch19:02:32

Are you thinking about security or more that the Clojure runtime will crash for some reason?

Avichal19:02:11

yes, I was initially thinking about security. But can it crash at runtime?

martinklepsch19:02:14

Ok, so I think with security we should be good because that option can only be provided via the configuration file when running the process. There's no way to change it from the outside

martinklepsch19:02:29

And it can crash if some namespace doesn't compile etc.

martinklepsch19:02:38

The usual reasons I guess

martinklepsch19:02:12

but we'll notice that as soon as the cljdoc server starts so it should be quite apparent and actually nomad won't promote the release if it doesn't become healthy after a while

Avichal19:02:52

got it. Sounds good then 👍