Fork me on GitHub
#cljdoc
<
2018-12-11
>
timgilbert14:12:22

Hello! Am I correct that the only bits cljdoc reads out of the <scm> tag in a pom.xml are the url and tag fields? It look like it to me from the source, just wanted to double-check

martinklepsch14:12:23

@timgilbert that sounds correct to me 😄

timgilbert14:12:50

Sweet, thanks

martinklepsch14:12:20

It does fall back the global <url> tag if there's no <scm> tag

martinklepsch14:12:40

Mind sharing why you're asking? 🙂

timgilbert14:12:33

I’m working on a little utility to post-process the results of clojure -Spom and rewrite the version, groupId and artifactId

timgilbert14:12:08

Since I’m in there anyways I figured I might as well try to put in the stuff cljdoc uses

martinklepsch14:12:30

ohh, that sounds useful — for packaging deps.edn based projects into jars and stuff?

timgilbert14:12:01

One thing I wasn’t sure about was whether there was some special sauce I needed to get the “view source” links to work correctly

timgilbert14:12:02

Yeah, precisely

martinklepsch14:12:39

We've been meaning to also package cljdoc as a jar just so we can put it on cljdoc as well 🙂

martinklepsch14:12:54

for view source links to work you need either a) a <tag> in the scm portion or b) a tag with the version string like 1.0.0 or v1.0.0

timgilbert14:12:04

You can partly do it right now by creating a pom.xml and using juxt/pack to make a skinny jar, but the deployment bit is not there yet

martinklepsch14:12:36

yeah, also I really don't like the way you have to post-process the clj -Spom pom.xml

martinklepsch14:12:09

there's a deps-deploy project though (linked in the issue above)

timgilbert14:12:46

Same, and I don’t like checking in partially-generated stuff into source control, package.lock be damned

timgilbert14:12:10

Oh right! I knew I’d seen one somewhere

martinklepsch14:12:21

Perhaps it would be helpful to "borrow" from boot's pom.xml generation stuff

dominicm08:12:44

This is how pack started!

martinklepsch14:12:35

(linked in the deps-deploy issue)

timgilbert14:12:22

Yeah, I looked at that. The actual code to update is pretty short, though, and I’m able to just invoke the clojure -Spom from tools.deps so it doesn’t need a separate JVM invocation

martinklepsch14:12:50

I see, I guess staying to the -Spom output as much as possible makes sense, thus updating might be the better approach

timgilbert14:12:13

Yeah, I’m going to go with it as a first approach. I have it working now, just need to see if I can get the full path to clojars to work

martinklepsch14:12:54

That would be awesome — please share your results in https://github.com/cljdoc/cljdoc/issues/206 if you don't mind 🙂

👍 4