Fork me on GitHub
#cljdoc
<
2018-11-14
>
martinklepsch16:11:38

made some significant progress getting cljdoc responsive today πŸŽ‰

parrot 20
elarouss21:11:39

hi everyone, hi @martinklepsch, i've watched your talk on ClojureTRE, good project well done :thumbsup: , i want this project to get my first open source contribution πŸ˜„, i'm kind of beginner so i won't be of that help, but i'll start navigating the code and hopefully i can help someday

πŸ‘ 12
martinklepsch21:11:14

Sounds great @ichigo β€” welcome to the crew! πŸ˜„

martinklepsch21:11:54

If you want I can point you to some easy first issues that you could try to work on to get familiar with the project setup etc.

elarouss21:11:38

thank you, yes please i would like to try

martinklepsch22:11:38

So this would be a pretty easy and actually pretty valueable thing to fix: https://github.com/cljdoc/cljdoc/issues/203

martinklepsch00:11:09

Feel free to ask more questions in the channel or here in case you need assistance. There are plenty of people around that are happy to help.

elarouss21:11:01

yeah thanks, i've seen that issue, so if i understand it right, the "more recent version" notification should not appear in case of the newer releases are just Snapshots, right ?

elarouss21:11:46

i think i need to know the shape of the cache bundle map passed to the cljdoc.bundle.more-recent-version function

martinklepsch22:11:17

In general that diff will be useful for a bit more context

elarouss22:11:55

@martinklepsch i'm sorry for being so beginner here 😳 , so we need to not put the snapshots in the db at first place i guess

elarouss22:11:14

but that looks out of the scope of that issue

martinklepsch22:11:07

No worries 😊 I think it might be easiest to just filter the list of versions to remove any versions ending with -SNAPSHOT before taking the last version in the line I linked to.

martinklepsch22:11:04

Hope that makes sense.

martinklepsch22:11:43

It might be helpful to just get the project running and experiment with the get-documented-versions function at the REPL

martinklepsch22:11:34

If you’re having trouble setting up a REPL with your editor (which is very handy) I can help you tomorrow or you can ask for help in #editors or #beginners

martinklepsch22:11:49

Good luck! πŸ˜„ (and good Night for now :)

elarouss22:11:34

hhhh thank you, i'm running the repl now, but yeah i need to use it from inside emacs

elarouss22:11:39

yeah that the first thing i thought about the -SNAPSHOT part, but because i'm like a stranger in a new town hhhh i'm too doubtful

elarouss22:11:35

thank you, good night for you too simple_smile

martinklepsch23:11:32

OMG I just git reset --hard a few hours of work facepalm Was able to recover most of it via open Emacs buffers but wow. Don't code at night kids! πŸ˜„

😴 4
😱 4
martinklepsch23:11:46

On the other hand the responsiveness stuff I got done today is amazing ✨ if I may humbly say so