Fork me on GitHub
#cljdoc
<
2018-10-17
>
martinklepsch13:10:50

@avichalp @rodolfo I invited you to the cljdoc GitHub team, please accept so I can bug you for code reviews 😄 https://github.com/orgs/cljdoc/teams/cljdoc-community

4
dominicm17:10:27

@martinklepsch feel like discussing the JUXT tooling is off topic for #boot, but I'm happy to help you out with combining kick and pack to do what you want 😊

martinklepsch17:10:39

@dominicm what the heck is kick? 😄

martinklepsch17:10:01

btw, this might be a good thing to do for pack as well (required for Java9+): https://github.com/martinklepsch/clj-http-lite/commit/3f41fc53a1b692549c88a8602e753cfb887330ae

dominicm17:10:54

@martinklepsch ties together figwheel/cljs/shadow/sass into a config, with reloading and minimal touching. Successor to krei.

martinklepsch17:10:11

ah, I remember krei 😄

martinklepsch17:10:51

@dominicm so with skinny, is that jar suitable to be uploaded to e.g. Clojars?

dominicm09:10:03

If you put a pom on the classpath, yep!

martinklepsch09:10:34

do you just use -Spom for that? I tried and it needs some manual adjustments because some directories get skipped making it a bit cumbersome

dominicm09:10:04

The directories probably aren't important for uploading to Clojars, if you use pack.

martinklepsch09:10:52

oh and also -Spom doesn't set the artifact id etc.

dominicm10:10:46

No, you have to set it yourself, but clj updates the pom once you have done that.

martinklepsch10:10:48

It inserted newlines every time I ran it when I tried 😄

martinklepsch10:10:26

Sorry if I'm being a diva here, I just can't believe that this isn't dead easy yet 😄

dominicm12:10:40

Newlines? I thought that was fixed, maybe not

martinklepsch13:10:30

could be I was on an older version...

martinklepsch17:10:14

I find the deps.edn -> Clojars deployment story surprisingly lacking so far

martinklepsch18:10:21

But I guess that's mostly due to people using it for apps and using other tools.deps stuff that's incompatible with jars (git checkouts etc.)

martinklepsch18:10:05

My current approach looks something like this:

./script/parcel build
git archive HEAD -o /tmp/cljdoc.tar
tar -rvf /tmp/cljdoc.tar resources
Then in prod untar, cd, clj -m ...

martinklepsch18:10:18

the additional tar append is to include the compiled JS files (which potentially should go into a different directory than regular resources)

drowsy22:10:26

I just trigged the build for instaparse (https://circleci.com/gh/martinklepsch/cljdoc-builder/5739#tests/containers/0) and it succeeded, but https://cljdoc.xyz/d/instaparse/instaparse/1.4.9 is still empty. What went wrong there?

martinklepsch08:10:23

In this case the error occurred on the cljdoc server while processing the Git repo or importing the data into the database. There's an issue to store these issues in the database so that the stacktrace can be shown on the builds page: https://github.com/cljdoc/cljdoc/issues/111

martinklepsch08:10:03

@U44SHEP4N the issue with instaparse is that it uses https://github.com/aengelberg/cljsee and always has .clj and .cljc files for each namespace. The analyzer then duplicates those namespaces in the analysis result because it discovers namespaces via files...

drowsy09:10:39

@martinklepsch Ah thanks for the explanation. Should I create an issue for this? I'm just scanning through one of my projects and try to create the docs for all the deps. I think only instaprase, timbre and specter are not working (when semantic-csv is working).

martinklepsch09:10:41

with timbre I think it's some missing dependencies but not 100% sure

martinklepsch09:10:06

(1.4.9 isn't as nice because it hasn't yet been tagged on GitHub)

martinklepsch09:10:21

unfortunately source links for Clojure are broken because the Clojure sources aren't on GitHub

drowsy10:10:06

Looks good 🙂. Btw. cljdoc is awesome and your handling/encouragement of new contributors fantastic!

martinklepsch10:10:40

Thanks, I do my best 🙂

drowsy23:10:05

oh https://cljdoc.xyz/builds/5347 shows an error, but it's not that verbose about the reason