Fork me on GitHub
#cljdoc
<
2018-10-13
>
drowsy00:10:47

Ok, I ended up replacing the dependency anyway, but maybe it's a use case for different projects too.

martinklepsch08:10:40

@drowsy currently only Clojars and Maven central are supported. Adding support for additional repositories isn't hard but since docs aren't namespaced by the artifact's repository it also increases the chance of conflicts

drowsy08:10:59

@martinklepsch right, but it's not about generating docs from other repos. The analyzer seems to ignore other repo definitions in the pom and can't build a projekt that actually is on clojars itself but pulls a dependency from somewhere else.

martinklepsch08:10:58

oh! you mean it's about transitive deps from the mulesoft repo?

drowsy08:10:27

yeah, for example in this case: https://cljdoc.xyz/builds/5118

drowsy08:10:58

I don't need it anymore as I replaced it and pushed a newer version, but it's not that uncommon in java land

martinklepsch08:10:57

How does it work in java? Does the pom.xml declare the additional repo in some way?

martinklepsch09:10:21

Or are consumers expected to add the repo to their config?

drowsy09:10:14

yeah, the pom has <repositories> where everything is listed, even central and clojars

martinklepsch09:10:40

Ok so I guess the analysis code should set repositories according to the analyzed projects pom.xml — if you could open an issue to track this that would be awesome 🙇

drowsy10:10:45

maybe I have time to look into this myself.

martinklepsch10:10:58

Thanks, that would also be awesome of course.

martinklepsch10:10:26

I added some notes to the issue that should provide some basic pointers to get going.

martinklepsch10:10:45

If you mainly use Cursive you might want to base your changes on the cursive branch for now.

martinklepsch08:10:43

I pushed some more changes to the cursive branch that should remove the need for the build-libs.sh script. If you're using Cursive it would be helpful if you could give it a test run and see if it's working as you would expect. https://github.com/cljdoc/cljdoc/pull/140

martinklepsch08:10:08

(the PR still includes the build-libs script but you should no longer need it)

drowsy09:10:22

I imported the cursive branch without further setup and it looks good. I tried starting repls for the main project and the analyzer, and both worked (when using "Run with deps").

👍 1
🙌 1
cfleming16:10:06

@martinklepsch @drowsy Awesome, thanks!