Fork me on GitHub
#cljdoc
<
2018-08-25
>
miikka07:08:48

Is the list of contribution area in https://github.com/cljdoc/cljdoc/blob/master/CONTRIBUTING.md still relevant?

martinklepsch11:08:34

@miikka unfortunately not, that doc needs a serious overhaul which I've been wanting to do for a while

martinklepsch11:08:52

@miikka I think right now the best way is probably checking out the "help wanted" issues: https://github.com/cljdoc/cljdoc/issues?q=is%3Aissue+is%3Aopen+label%3A%22Help+Wanted%22 perhaps focusing on the "good first issue" ones first

martinklepsch11:08:47

I'm also aware that many of these are "smallish" and maybe not super interesting in the long run so happy to discuss any larger projects too (spec integration, examples etc.)

thheller11:08:34

@martinklepsch did you experiment with non-nested namespaces on the left nav? I find it incredibly hard to make out what the full ns is since I can't make out if its nested 2 or 3 levels sometimes. so instead of just dom with margin-left:20px just fulcro.client.dom? I think it would be cleaner with the full names?

martinklepsch12:08:30

@thheller that's been the first version but the issue is that long namespaces cause horizontal scrolling (or a very wide sidebar)

martinklepsch12:08:54

@thheller I think the issue could be mitigated with some tree style lines as codox does them

thheller12:08:42

was looking throught https://cljdoc.xyz/d/fulcrologic/fulcro/2.6.0/doc/readme and it has lots of namespaces. so scrolling down you kinda lose context what the parents are

thheller12:08:28

maybe just use fixed width with text-overflow: ellipsis;?

martinklepsch12:08:45

some hover effect that shows the full ns could also help but less obvious since only shown in hover state

martinklepsch12:08:18

that would truncate at the end which is usually the most important part of a namespace

thheller12:08:47

true. I'll probably get used to the nesting

martinklepsch12:08:33

I think the lines might make a notable difference but haven’t had time to implement them

martinklepsch12:08:15

If you feel like opening an issue to keep track of some of the ideas we discussed please do 🙂

dominicm14:08:32

I wonder if something vertical could work? :thinking_face:

martinklepsch14:08:04

@dominicm not sure what you mean? Vertical text?