clj-yaml

lread 2022-09-19T16:02:28.503429Z

I think minimal effort includes keeping the clj-yaml changelog up to date. simple_smile I’ll catch us up.

1
borkdude 2022-09-19T16:11:51.021749Z

Is it possible to disable "review wanted as a code owner" for things that you don't really need to review, like adding something like .gitignore, and only getting an e-mail if someone actually wants a code review?

lread 2022-09-19T16:14:26.156349Z

I had a peek a while ago. I did not see a way to turn off auto review invites for code owners.

borkdude 2022-09-19T16:15:18.636619Z

I'll just delete all the review wanted e-mails then and if you really want a review, ping me

lread 2022-09-19T16:15:35.432419Z

Yeah, that works for now. Ditto.

lread 2022-09-19T16:33:44.140189Z

Ah. That little * is https://github.blog/2017-07-06-introducing-code-owners/ for what files a CODEOWNER will be pinged to review:

* @marcomorain @slipset @borkdude @lread 
I’m sure this is useful for some projects, but I don’t see it as useful for us. To disable, some folks just change it to:
.github/CODEOWNERS @marcomorain @slipset @borkdude @lread 
I will make it so (with a comment explaining).

borkdude 2022-09-19T16:36:40.625929Z

thank you!

lread 2022-09-19T16:46:42.524259Z

Done! If it actually works, I’ll apply it to other clj-commons projects where I am a code owner.

🎉 1
lread 2022-09-19T16:51:25.735209Z

Hopefully I don’t offend any of you by switching changelog from md to adoc. If it bothers you, just think of it as the cost of me doing this mind-numbing work!

borkdude 2022-09-19T17:43:05.070779Z

I won't object

lread 2022-09-19T18:44:05.593999Z

Looks like my CODEOWNERS tweak worked! 🎉

borkdude 2022-09-19T18:44:57.879139Z

At last, something that works!

lread 2022-09-19T18:45:29.253349Z

If the CODEOWNERS file was in YAML, I don’t think it would have been possible.

borkdude 2022-09-19T18:45:42.983669Z

let alone if your name starts with a 0!

1