Fork me on GitHub
#clj-yaml
<
2022-09-19
>
lread16:09:28

I think minimal effort includes keeping the clj-yaml changelog up to date. simple_smile I’ll catch us up.

gratitude 1
borkdude16:09:51

Is it possible to disable "review wanted as a code owner" for things that you don't really need to review, like adding something like .gitignore, and only getting an e-mail if someone actually wants a code review?

lread16:09:26

I had a peek a while ago. I did not see a way to turn off auto review invites for code owners.

borkdude16:09:18

I'll just delete all the review wanted e-mails then and if you really want a review, ping me

lread16:09:35

Yeah, that works for now. Ditto.

lread16:09:44

Ah. That little * is https://github.blog/2017-07-06-introducing-code-owners/ for what files a CODEOWNER will be pinged to review:

* @marcomorain @slipset @borkdude @lread 
I’m sure this is useful for some projects, but I don’t see it as useful for us. To disable, some folks just change it to:
.github/CODEOWNERS @marcomorain @slipset @borkdude @lread 
I will make it so (with a comment explaining).

lread16:09:42

Done! If it actually works, I’ll apply it to other clj-commons projects where I am a code owner.

🎉 1
lread16:09:25

Hopefully I don’t offend any of you by switching changelog from md to adoc. If it bothers you, just think of it as the cost of me doing this mind-numbing work!

borkdude17:09:05

I won't object

lread18:09:05

Looks like my CODEOWNERS tweak worked! 🎉

borkdude18:09:57

At last, something that works!

lread18:09:29

If the CODEOWNERS file was in YAML, I don’t think it would have been possible.

borkdude18:09:42

let alone if your name starts with a 0!

simple_smile 1