This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2023-09-19
Channels
- # announcements (1)
- # babashka (40)
- # beginners (84)
- # biff (46)
- # calva (37)
- # cherry (2)
- # cider (18)
- # clj-otel (5)
- # clojure (53)
- # clojure-europe (39)
- # clojure-hungary (12)
- # clojure-norway (40)
- # clojure-sweden (2)
- # clojure-uk (2)
- # clojurescript (6)
- # community-development (21)
- # cursive (28)
- # data-science (12)
- # datomic (3)
- # figwheel-main (2)
- # fulcro (12)
- # graalvm (7)
- # gratitude (1)
- # hyperfiddle (23)
- # integrant (9)
- # jobs (2)
- # leiningen (4)
- # lsp (8)
- # malli (3)
- # missionary (1)
- # off-topic (39)
- # polylith (3)
- # portal (33)
- # practicalli (4)
- # re-frame (3)
- # releases (1)
- # sci (53)
- # solo-full-stack (8)
- # sql (5)
- # timbre (9)
is there any appetite for handling keywords for span names automatically? i find myself doing this a lot
(span/with-span! {:name (qualified-name ::my-span-name)}
...)
This sounds like a fair idea π I like the idea of supporting alternatives to the span options map where it appears in the clj-api
api. Supporting a string or keyword to provide a span name seems very reasonable. I think supporting the common case of supplying a span name and attributes would also be worthwhile.
An aside on steffan-westcott.clj-otel.util/qualified-name
: The https://opentelemetry.io/docs/specs/otel/common/attribute-naming/ says that the attribute base name should be in snake_case. However, the https://opentelemetry.io/docs/specs/otel/trace/api/#span does not have this stipulation for span names. qualified-name
is intended to be used for attribute names only, as it formats qualified keywords and converts all to snake_case. Using namespace-qualified keywords for span names is a good practice, but it is not required (and undesirable) to also convert them to snake_case.