Fork me on GitHub
#clj-otel
<
2022-06-25
>
devurandom20:06:21

Hi @steffan! In the readme you write "There is presently no coverage of the Metrics or Logs API. Work on these will commence shortly." Did you already start working on this? Can I maybe already try it out?

steffan22:06:26

clj-otel does not have Metrics or Logs support at the moment. The good news is work will start in this area over the next couple of weeks. I have been busy with personal issues which have slowed progress on clj-otel, but signs are that things should be resolved soon. I appreciate your patience in the meanwhile 🙂

🙏 1
steffan22:06:02

The OpenTelemetry Metrics API has been declared stable fairly recently, although the SDK has not quite reached that milestone yet. When clj-otel was first released, the Metrics API was not stable so was not a great place to put much development focus. Now some stability is there, it's a better time to add Metrics support in clj-otel.

👍 2
devurandom21:06:31

I am using this interceptor:

(def add-route-data
  {:name ::add-route-data
   :enter (fn [context]
            (http/add-route-data! (-> context :route :path))
            context)})
Would that be a good fit to add to http/server-span-interceptors?

steffan22:06:20

That is very interesting, I will look into that. Thank you for the heads up 🙂

steffan22:06:21

Do you happen to know if this route information is always present irrespective of which router is used?

devurandom17:06:52

My interpretation of this is that any implementation of the RouterSpecification protocol does this, but better read it yourself -- I do not know much about these internals of Pedestal.

devurandom21:07:48

Thank you for including this in 0.1.4!

1