2022-06-25 clj-otel | Clojure Slack Archive

clj-otel

devurandom 2022-06-25T20:42:21.775949Z

Hi @steffan! In the readme you write "There is presently no coverage of the Metrics or Logs API. Work on these will commence shortly." Did you already start working on this? Can I maybe already try it out?

steffan 2022-06-25T22:16:26.537339Z

clj-otel does not have Metrics or Logs support at the moment. The good news is work will start in this area over the next couple of weeks. I have been busy with personal issues which have slowed progress on clj-otel, but signs are that things should be resolved soon. I appreciate your patience in the meanwhile 🙂

🙏 1

steffan 2022-06-25T22:32:02.595879Z

The OpenTelemetry Metrics API has been declared stable fairly recently, although the SDK has not quite reached that milestone yet. When clj-otel was first released, the Metrics API was not stable so was not a great place to put much development focus. Now some stability is there, it's a better time to add Metrics support in clj-otel.

👍 2

devurandom 2022-06-25T21:24:31.320849Z

I am using this interceptor:

(def add-route-data
  {:name ::add-route-data
   :enter (fn [context]
            (http/add-route-data! (-> context :route :path))
            context)})

Would that be a good fit to add to http/server-span-interceptors?

steffan 2022-06-25T22:19:20.163939Z

That is very interesting, I will look into that. Thank you for the heads up 🙂

steffan 2022-06-25T22:20:21.989819Z

Do you happen to know if this route information is always present irrespective of which router is used?

devurandom 2022-07-05T21:24:48.424049Z

Thank you for including this in 0.1.4!

🙇🏻‍♂️ 1

devurandom 2022-06-26T17:02:21.710819Z

I found the hint about it here: http://pedestal.io/api/pedestal.route/io.pedestal.http.route.html#var-router-spec

👍🏻 1

devurandom 2022-06-26T17:03:52.027649Z

My interpretation of this is that any implementation of the RouterSpecification protocol does this, but better read it yourself -- I do not know much about these internals of Pedestal.

devurandom 2022-06-25T00:11:44.474249Z

@devurandom has joined the channel

Clojurians Log v2

clj-otel