Clojurians Log v2

Couldn't the same be said for the (not (empty? x)) -> (seq x) one?

That one is controversial now since clojure 1.12

it was actually relaxed in recent clj-kondo versions

Shouldn't those use when-some and if-some

@alexmiller those create a binding which might not be needed

if I'm not wrong

Ah

> controversial now since clojure 1.12 what's a good documentation of this?

@borkdude to circle back to the OP, I usually prefer the latter forms, i.e. the ones using some? but it can be a style preference thing. Perhaps default to off?

@imre https://github.com/clj-kondo/clj-kondo/issues/1743

hah

related to this, the not-empty? linter does not warn when we use when-not or if-not maybe it should?

>   clojure -M:clj-kondo/dev --lint - <<< "(when (not (empty? (map identity [1]))) true)"

<stdin>:1:12: warning: Use (seq x) instead of (not (empty? x)) when x is a seq
linting took 40ms, errors: 0, warnings: 1
>   clojure -M:clj-kondo/dev --lint - <<< "(when-not (empty? (map identity [1])) true)"

linting took 33ms, errors: 0, warnings: 0

I discovered that in hot paths (when-not (nil? ...)) is faster than (when (some? ...)) since some? is a var call

so I'm going to add that warning to the linter docs. it's off by default anyway so it's fine

CLJS does optimize some? to != null